Remove DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() (#12147)

DOM_NO_ARGS() has no users.
DOM_NOT_IMPLEMENTED() has a single user.
This commit is contained in:
Niels Dossche 2023-09-08 17:02:52 +02:00 committed by GitHub
parent 8f8f31a16a
commit ac62eee842
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 10 deletions

View File

@ -25,6 +25,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
a. ext/dom
- dom_read_t and dom_write_t now expect the function to return zend_result
instead of int.
- The macros DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() have been removed.
========================
4. OpCode changes

View File

@ -227,7 +227,8 @@ PHP_METHOD(DOMImplementation, getFeature)
RETURN_THROWS();
}
DOM_NOT_IMPLEMENTED();
zend_throw_error(NULL, "Not yet implemented");
RETURN_THROWS();
}
/* }}} end dom_domimplementation_get_feature */

View File

@ -188,15 +188,6 @@ int php_dom_get_nodelist_length(dom_object *obj);
__ptr = (__prtype)((php_libxml_node_ptr *)__intern->ptr)->node; \
}
#define DOM_NO_ARGS() \
if (zend_parse_parameters_none() == FAILURE) { \
RETURN_THROWS(); \
}
#define DOM_NOT_IMPLEMENTED() \
zend_throw_error(NULL, "Not yet implemented"); \
RETURN_THROWS();
#define DOM_NODELIST 0
#define DOM_NAMEDNODEMAP 1