Simple fix that just quotes the filenames in run-tests to support paths with spaces.

Fixes bug #60734
This commit is contained in:
Rasmus Lerdorf 2012-01-28 02:43:31 +00:00
parent acaf9c5227
commit a2ce8b3f97

View File

@ -1521,7 +1521,7 @@ TEST $file
if ($JUNIT) {
$test_started_at = microtime(true);
}
$output = system_with_timeout("$extra $php $pass_options -q $ini_settings -d display_errors=0 $test_skipif", $env);
$output = system_with_timeout("$extra $php $pass_options -q $ini_settings -d display_errors=0 \"$test_skipif\"", $env);
if ($JUNIT) {
$test_finished_at = microtime(true);
$test_execution_time= number_format($test_finished_at-$test_started_at, 2);
@ -1716,7 +1716,7 @@ TEST $file
}
save_text($tmp_post, $request);
$cmd = "$php $pass_options $ini_settings -f \"$test_file\" 2>&1 < $tmp_post";
$cmd = "$php $pass_options $ini_settings -f \"$test_file\" 2>&1 < \"$tmp_post\"";
} else if (array_key_exists('POST', $section_text) && !empty($section_text['POST'])) {
@ -1737,7 +1737,7 @@ TEST $file
$env['CONTENT_TYPE'] = 'application/x-www-form-urlencoded';
$env['CONTENT_LENGTH'] = $content_length;
$cmd = "$php $pass_options $ini_settings -f \"$test_file\" 2>&1 < $tmp_post";
$cmd = "$php $pass_options $ini_settings -f \"$test_file\" 2>&1 < \"$tmp_post\"";
} else {
@ -1795,7 +1795,7 @@ COMMAND $cmd
settings2params($clean_params);
$extra = substr(PHP_OS, 0, 3) !== "WIN" ?
"unset REQUEST_METHOD; unset QUERY_STRING; unset PATH_TRANSLATED; unset SCRIPT_FILENAME; unset REQUEST_METHOD;": "";
system_with_timeout("$extra $php $pass_options -q $clean_params $test_clean", $env);
system_with_timeout("$extra $php $pass_options -q $clean_params \"$test_clean\"", $env);
}
if (!$cfg['keep']['clean']) {