diff --git a/TODO b/TODO index 3bfc5c6301a..450d69bb795 100644 --- a/TODO +++ b/TODO @@ -3,6 +3,8 @@ parenthesis means that person has taken on this project. global ------ + * make sure that all ZTS globals get destructed. Most ts_allocate_id() + calls should have a dtor entry. * activate all extensions by default that don't rely on external dependices. (eg ftp) * --enable-all in configure. (--enable-shared=max ...) diff --git a/ext/xml/xml.c b/ext/xml/xml.c index b560b94b8cd..0653ace9987 100644 --- a/ext/xml/xml.c +++ b/ext/xml/xml.c @@ -164,7 +164,7 @@ PHP_MINIT_FUNCTION(xml) le_xml_parser = register_list_destructors(xml_parser_dtor, NULL); #ifdef ZTS - xml_globals_id = ts_allocate_id(sizeof(php_xml_globals), php_xml_init_globals, NULL); + xml_globals_id = ts_allocate_id(sizeof(php_xml_globals), (ts_allocate_ctor) php_xml_init_globals, NULL); #else XML(default_encoding) = "ISO-8859-1"; #endif