mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-12-18 06:21:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update documentation/comment for GH-4860

Browse Source 
Fix folding for the new helper method.

Clarify comment in UPGRADING:
The performance on associative arrays would also improve,
as long as no offsets were unset (no gaps).
Packed arrays can have gaps.

Closes GH-4873.
[ci skip]
This commit is contained in:
Tyson Andre 2019-10-29 19:48:28 -04:00 committed by Nikita Popov
parent fee94da127
commit 96f361dca0
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
UPGRADING
View File

@ -371,6 +371,6 @@ PHP 8.0 UPGRADE NOTES
14. Performance Improvements
========================================
- array_slice() on a packed array will no longer scan the whole array to find
- array_slice() on an array without gaps will no longer scan the whole array to find
the start offset. This may significantly reduce the runtime of the function
with large offsets and small lengths.

1
ext/standard/array.c
View File

@ -3480,6 +3480,7 @@ static inline Bucket* find_bucket_at_offset(HashTable* ht, zend_long offset)
/* Return a pointer to the end of the bucket array. */
return ht->arData + ht->nNumUsed;
}
/* }}} */
/* {{{ proto array array_slice(array input, int offset [, int length [, bool preserve_keys]])
Returns elements specified by offset and length */