mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-23 18:04:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #77051: Issue with re-binding on SQLite3

Browse Source 
We have to call `sqlite3_reset()` before re-binding the parameters.
This commit is contained in:
BohwaZ 2018-11-22 16:57:55 +01:00 committed by Christoph M. Becker
parent 4ac764e8bb
commit 94ec262fca
3 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS
View File

@ -37,6 +37,9 @@ PHP NEWS
. Fixed bug #77136 (Unsupported IPV6_RECVPKTINFO constants on macOS).
(Mizunashi Mana)
- SQLite3:
. Fixed bug #77051 (Issue with re-binding on SQLite3). (BohwaZ)
06 Dec 2018, PHP 7.2.13
- ftp:

3
ext/sqlite3/sqlite3.c
View File

@ -1568,6 +1568,9 @@ PHP_METHOD(sqlite3stmt, execute)
SQLITE3_CHECK_INITIALIZED(stmt_obj->db_obj, stmt_obj->initialised, SQLite3);
/* Always reset statement before execution, see bug #77051 */
sqlite3_reset(stmt_obj->stmt);
if (stmt_obj->bound_params) {
ZEND_HASH_FOREACH_PTR(stmt_obj->bound_params, param) {
zval *parameter;

84
ext/sqlite3/tests/bug77051.phpt Normal file
View File

@ -0,0 +1,84 @@
--TEST--
Bug #77051 SQLite3::bindParam memory bug when missing ::reset call
--SKIPIF--
<?php require_once(__DIR__ . '/skipif.inc'); ?>
--FILE--
<?php
$db = new SQLite3(':memory:');
$db->enableExceptions(true);
$stmt = $db->prepare('SELECT :a, :b, ?;');
$a = 42;
$stmt->bindParam(':a', $a, SQLITE3_INTEGER);
$stmt->bindValue(':b', 'php');
$stmt->bindValue(':b', 'PHP');
$stmt->bindValue(3, 424242);
echo "Execute statement\n";
var_dump($res = $stmt->execute());
echo "Statement result\n";
var_dump($res->fetchArray(SQLITE3_NUM));
echo "Change binded param to wrong type\n";
$a = 'TEST';
echo "Execute statement\n";
var_dump($res = $stmt->execute());
echo "Statement result\n";
var_dump($res->fetchArray(SQLITE3_NUM));
echo "Change binded values\n";
$a = 5252552;
$stmt->bindValue(':b', 'TEST');
$stmt->bindValue(3, '!!!');
echo "Execute statement\n";
var_dump($res = $stmt->execute());
echo "Statement result\n";
var_dump($res->fetchArray(SQLITE3_NUM));
?>
--EXPECTF--
Execute statement
object(SQLite3Result)#3 (0) {
}
Statement result
array(3) {
[0]=>
int(42)
[1]=>
string(3) "PHP"
[2]=>
int(424242)
}
Change binded param to wrong type
Execute statement
object(SQLite3Result)#4 (0) {
}
Statement result
array(3) {
[0]=>
int(0)
[1]=>
string(3) "PHP"
[2]=>
int(424242)
}
Change binded values
Execute statement
object(SQLite3Result)#3 (0) {
}
Statement result
array(3) {
[0]=>
int(5252552)
[1]=>
string(4) "TEST"
[2]=>
string(3) "!!!"
}