mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-23 18:04:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix preg_replace_callback_array() pattern validation

Browse Source 
Closes GH-11301
This commit is contained in:
Ilija Tovilo 2023-05-23 13:55:50 +02:00
parent 4676d9bc43
commit 7c7698f754
No known key found for this signature in database
GPG Key ID: A4F5D403F118200A
3 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS
View File

@ -2,6 +2,9 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.2.8
- PCRE:
. Fix preg_replace_callback_array() pattern validation. (ilutov)
- Standard:
. Fix access on NULL pointer in array_merge_recursive(). (ilutov)

4
ext/pcre/php_pcre.c
View File

@ -2425,6 +2425,10 @@ PHP_FUNCTION(preg_replace_callback_array)
zend_argument_type_error(1, "must contain only valid callbacks");
goto error;
}
if (!str_idx_regex) {
zend_argument_type_error(1, "must contain only string patterns as keys");
goto error;
}
ZVAL_COPY_VALUE(&fci.function_name, replace);

15
ext/pcre/tests/preg_replace_callback_array_numeric_index_error.phpt Normal file
View File

@ -0,0 +1,15 @@
--TEST--
preg_replace_callback_array() invalid pattern
--FILE--
<?php
preg_replace_callback_array(
[42 => function () {}],
'a',
);
?>
--EXPECTF--
Fatal error: Uncaught TypeError: preg_replace_callback_array(): Argument #1 ($pattern) must contain only string patterns as keys in %s:%d
Stack trace:
#0 %s(%d): preg_replace_callback_array(Array, 'a')
#1 {main}
thrown in %s on line %d