From 6f617b7759a12c341a055de42e06717ebf905130 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Wed, 17 Jul 2019 19:25:36 +0200 Subject: [PATCH] Revert "Remove Windows syslog script and syslog.reg" This reverts commit cc44bad1f6ded6a62c9bbe4d145b5b418aa775f4, since its assumptions were not correct. Actually, the classic event logging is still used by PHP, because Windows 7 is still to be supported for a while. Without the respective registry entries, the event log entries show an error message regarding missing ID descriptions. Thanks to ab@php.net for hinting at this! Obviously, the part depending on ext/win32std has still to be overhauled, and further improvements are conceivable; we will address this in due course. --- win32/build/Makefile | 3 +++ win32/build/registersyslog.php | 44 ++++++++++++++++++++++++++++++++++ win32/syslog.reg | 5 ++++ 3 files changed, 52 insertions(+) create mode 100755 win32/build/registersyslog.php create mode 100644 win32/syslog.reg diff --git a/win32/build/Makefile b/win32/build/Makefile index a4d82e06fb1..26b73b625ac 100644 --- a/win32/build/Makefile +++ b/win32/build/Makefile @@ -261,3 +261,6 @@ really-install: @type nul > $(BUILD_DIR)\extension_dlls.txt @if exist $(BUILD_DIR)\php_*.dll copy $(BUILD_DIR)\php_*.dll $(PHP_PREFIX)\ext /y >nul & dir /b $(BUILD_DIR)\php_*.dll > $(BUILD_DIR)\extension_dlls.txt @xcopy $(BUILD_DIR)\*.dll /exclude:$(BUILD_DIR)\extension_dlls.txt $(PHP_PREFIX) /y >nul + @echo Registering event source with syslog (requires admin rights) + @echo It's okay for this step to fail: + -$(PHP_PREFIX)\php.exe -n -dextension_dir=$(PHP_PREFIX) win32/build/registersyslog.php $(PHP_PREFIX)\$(PHPDLL) diff --git a/win32/build/registersyslog.php b/win32/build/registersyslog.php new file mode 100755 index 00000000000..ce28cbf4201 --- /dev/null +++ b/win32/build/registersyslog.php @@ -0,0 +1,44 @@ + diff --git a/win32/syslog.reg b/win32/syslog.reg new file mode 100644 index 00000000000..a817b52faf2 --- /dev/null +++ b/win32/syslog.reg @@ -0,0 +1,5 @@ +REGEDIT4 + +[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Eventlog\Application\PHP-7.3.0-dev] +"TypesSupported"=dword:00000007 +"EventMessageFile"="g:\\test\\srctrunkinstall\\php7ts.dll"