From 673bbff0e508ea7ad89a9772f8a48dbe92ecc591 Mon Sep 17 00:00:00 2001 From: Kalle Sommer Nielsen Date: Sat, 19 Nov 2016 10:10:48 +0100 Subject: [PATCH] Updated the comment regarding what priority modes that are left out for the nice() implementation on Windows --- win32/nice.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/win32/nice.c b/win32/nice.c index 202a4d8e35d..d2487074fc6 100644 --- a/win32/nice.c +++ b/win32/nice.c @@ -47,7 +47,18 @@ * This is applied to the main process, not per thread, although this could * be implemented using SetThreadPriority() at one point. * - * Note, it is intended that some priority classes are left out. + * Note, the following priority classes are left out with intention: + * + * . REALTIME_PRIORITY_CLASS + * Realtime priority class requires special system permissions to set, and + * can be dangerous in certain cases. + * + * . PROCESS_MODE_BACKGROUND_BEGIN + * . PROCESS_MODE_BACKGROUND_END + * Process mode is not covered because it can easily forgotten to be changed + * back and can cause unforseen side effects that is hard to debug. Besides + * that, these do generally not really fit into making a Windows somewhat + * compatible nice() function. */ PHPAPI int nice(zend_long p)