mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-27 03:44:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change Big Endian backup implementations to use signed indexes

Browse Source 
load64() counted down from 7..0, but the decrement turned 0 into 255.
This means the loop would never terminate on Big Endian systems.

Just use signed char integers since we're only dealing with values from 0..7 anyway.

Closes https://bugs.php.net/bug.php?id=73282
This commit is contained in:
Sara Golemon 2016-10-11 20:43:02 -07:00
parent a5458e7e8e
commit 65d7bbaddc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext/hash/hash_sha3.c
View File

@ -38,7 +38,7 @@ static inline unsigned char idx(unsigned char x, unsigned char y) {
#ifdef WORDS_BIGENDIAN
static inline uint64_t load64(const unsigned char* x) {
unsigned char i;
char i;
uint64_t ret = 0;
for (i = 7; i >= 0; --i) {
ret <<= 8;
@ -47,14 +47,14 @@ static inline uint64_t load64(const unsigned char* x) {
return ret;
}
static inline void store64(unsigned char* x, uint64_t val) {
unsigned char i;
char i;
for (i = 0; i < 8; ++i) {
x[i] = val & 0xFF;
val >>= 8;
}
}
static inline void xor64(unsigned char* x, uint64_t val) {
unsigned char i;
char i;
for (i = 0; i < 8; ++i) {
x[i] ^= val & 0xFF;
val >>= 8;