mirror of
https://github.com/php/php-src.git
synced 2024-12-25 09:49:08 +08:00
Notice if CURLOPT_SSL_VERIFYHOST is set to true
This commit is contained in:
parent
7b4a53e263
commit
3b85d09de7
@ -2014,6 +2014,10 @@ static int _php_curl_setopt(php_curl *ch, long option, zval **zvalue, zval *retu
|
||||
|
||||
switch (option) {
|
||||
/* Long options */
|
||||
case CURLOPT_SSL_VERIFYHOST:
|
||||
if(Z_TYPE_PP(zvalue)==IS_BOOL && Z_BVAL_PP(zvalue)) {
|
||||
php_error_docref(NULL TSRMLS_CC, E_NOTICE, "CURLOPT_SSL_VERIFYHOST set to true which disables common name validation (setting CURLOPT_SSL_VERIFYHOST to 2 enables common name validation)");
|
||||
}
|
||||
case CURLOPT_AUTOREFERER:
|
||||
case CURLOPT_BUFFERSIZE:
|
||||
case CURLOPT_CLOSEPOLICY:
|
||||
@ -2048,7 +2052,6 @@ static int _php_curl_setopt(php_curl *ch, long option, zval **zvalue, zval *retu
|
||||
case CURLOPT_PUT:
|
||||
case CURLOPT_RESUME_FROM:
|
||||
case CURLOPT_SSLVERSION:
|
||||
case CURLOPT_SSL_VERIFYHOST:
|
||||
case CURLOPT_SSL_VERIFYPEER:
|
||||
case CURLOPT_TIMECONDITION:
|
||||
case CURLOPT_TIMEOUT:
|
||||
|
29
ext/curl/tests/bug63363.phpt
Normal file
29
ext/curl/tests/bug63363.phpt
Normal file
@ -0,0 +1,29 @@
|
||||
--TEST--
|
||||
Bug #63363 (CURL silently accepts boolean value for SSL_VERIFYHOST)
|
||||
--SKIPIF--
|
||||
<?php
|
||||
if (!extension_loaded("curl")) {
|
||||
exit("skip curl extension not loaded");
|
||||
}
|
||||
|
||||
?>
|
||||
--FILE--
|
||||
<?php
|
||||
$ch = curl_init();
|
||||
var_dump(curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false));
|
||||
/* Case that should throw an error */
|
||||
var_dump(curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, true));
|
||||
var_dump(curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0));
|
||||
var_dump(curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 1));
|
||||
var_dump(curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 2));
|
||||
|
||||
curl_close($ch);
|
||||
?>
|
||||
--EXPECTF--
|
||||
bool(true)
|
||||
|
||||
Notice: curl_setopt(): CURLOPT_SSL_VERIFYHOST set to true which disables common name validation (setting CURLOPT_SSL_VERIFYHOST to 2 enables common name validation) in %s on line %d
|
||||
bool(true)
|
||||
bool(true)
|
||||
bool(true)
|
||||
bool(true)
|
Loading…
Reference in New Issue
Block a user