mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-01-20 10:43:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

- Fixed bug #53463 (sqlite3 columnName() segfaults on bad column_number)

Browse Source
This commit is contained in:
Felipe Pena 2010-12-03 21:05:44 +00:00
parent 17d1b1310e
commit 26d7aafb1a
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ext/sqlite3/sqlite3.c
View File

@ -1529,6 +1529,7 @@ PHP_METHOD(sqlite3result, columnName)
php_sqlite3_result *result_obj;
zval *object = getThis();
long column = 0;
char *column_name;
result_obj = (php_sqlite3_result *)zend_object_store_get_object(object TSRMLS_CC);
SQLITE3_CHECK_INITIALIZED(result_obj->db_obj, result_obj->stmt_obj->initialised, SQLite3Result)
@ -1536,8 +1537,13 @@ PHP_METHOD(sqlite3result, columnName)
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &column) == FAILURE) {
return;
}
column_name = (char*) sqlite3_column_name(result_obj->stmt_obj->stmt, column);
RETVAL_STRING((char*)sqlite3_column_name(result_obj->stmt_obj->stmt, column), 1);
if (column_name == NULL) {
RETURN_FALSE;
}
RETVAL_STRING(column_name, 1);
}
/* }}} */

28
ext/sqlite3/tests/bug53463.phpt Normal file
View File

@ -0,0 +1,28 @@
--TEST--
Bug #53463 (sqlite3 columnName() segfaults on bad column_number)
--FILE--
<?php
$db = new SQLite3(':memory:');
$db->exec('CREATE TABLE test (whatever INTEGER)');
$db->exec('INSERT INTO test (whatever) VALUES (1)');
$result = $db->query('SELECT * FROM test');
while ($row = $result->fetchArray(SQLITE3_NUM)) {
var_dump($result->columnName(0)); // string(8) "whatever"
// Seems returning false will be most appropriate.
var_dump($result->columnName(3)); // Segmentation fault
}
$result->finalize();
$db->close();
echo "Done\n";
?>
--EXPECT--
string(8) "whatever"
bool(false)
Done