diff --git a/crypto/cms/cms_ec.c b/crypto/cms/cms_ec.c index 082fb5c4c9..be9c6ff893 100644 --- a/crypto/cms/cms_ec.c +++ b/crypto/cms/cms_ec.c @@ -48,7 +48,7 @@ static EVP_PKEY *pkey_type2param(int ptype, const void *pval, if (pctx == NULL || EVP_PKEY_paramgen_init(pctx) <= 0) goto err; if (OBJ_obj2txt(groupname, sizeof(groupname), poid, 0) <= 0 - || !EVP_PKEY_CTX_set_group_name(pctx, groupname)) { + || EVP_PKEY_CTX_set_group_name(pctx, groupname) <= 0) { ERR_raise(ERR_LIB_CMS, CMS_R_DECODE_ERROR); goto err; } diff --git a/ssl/s3_lib.c b/ssl/s3_lib.c index 5b9d21b566..1091b8831d 100644 --- a/ssl/s3_lib.c +++ b/ssl/s3_lib.c @@ -4720,7 +4720,7 @@ EVP_PKEY *ssl_generate_pkey_group(SSL *s, uint16_t id) SSLfatal(s, SSL_AD_INTERNAL_ERROR, ERR_R_EVP_LIB); goto err; } - if (!EVP_PKEY_CTX_set_group_name(pctx, ginf->realname)) { + if (EVP_PKEY_CTX_set_group_name(pctx, ginf->realname) <= 0) { SSLfatal(s, SSL_AD_INTERNAL_ERROR, ERR_R_EVP_LIB); goto err; } @@ -4754,7 +4754,7 @@ EVP_PKEY *ssl_generate_param_group(SSL *s, uint16_t id) goto err; if (EVP_PKEY_paramgen_init(pctx) <= 0) goto err; - if (!EVP_PKEY_CTX_set_group_name(pctx, ginf->realname)) { + if (EVP_PKEY_CTX_set_group_name(pctx, ginf->realname) <= 0) { SSLfatal(s, SSL_AD_INTERNAL_ERROR, ERR_R_EVP_LIB); goto err; } diff --git a/test/evp_extra_test.c b/test/evp_extra_test.c index b7f2fe7e28..4518271a82 100644 --- a/test/evp_extra_test.c +++ b/test/evp_extra_test.c @@ -1759,7 +1759,7 @@ static int test_EC_keygen_with_enc(int idx) /* Create key parameters */ if (!TEST_ptr(pctx = EVP_PKEY_CTX_new_from_name(testctx, "EC", NULL)) || !TEST_int_gt(EVP_PKEY_paramgen_init(pctx), 0) - || !TEST_true(EVP_PKEY_CTX_set_group_name(pctx, "P-256")) + || !TEST_int_gt(EVP_PKEY_CTX_set_group_name(pctx, "P-256"), 0) || !TEST_true(EVP_PKEY_CTX_set_ec_param_enc(pctx, enc)) || !TEST_true(EVP_PKEY_paramgen(pctx, ¶ms)) || !TEST_ptr(params))