mirrors/openssl
0
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2024-12-22 08:23:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

RT2849: Redundant check of "dsa" variable.

Browse Source 
In the current code, the check isn't redundant.
And in fact the REAL check was missing.
This avoids a NULL-deref crash.

Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
This commit is contained in:
Rich Salz 2014-09-04 12:55:31 -04:00
parent 683cd7c948
commit 3173622ef6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fips/dsa/fips_dssvs.c
View File

@ -552,6 +552,11 @@ static void keypair(FILE *in, FILE *out)
int n=atoi(value); int n=atoi(value);
dsa = FIPS_dsa_new(); dsa = FIPS_dsa_new();
if (!dsa)
{
fprintf(stderr, "DSA allocation error\n");
exit(1);
}
if (!dsa2 && !dsa_builtin_paramgen(dsa, L, N, NULL, NULL, 0, if (!dsa2 && !dsa_builtin_paramgen(dsa, L, N, NULL, NULL, 0,
NULL, NULL, NULL, NULL)) NULL, NULL, NULL, NULL))
{ {
@ -578,8 +583,7 @@ static void keypair(FILE *in, FILE *out)
do_bn_print_name(out, "Y",dsa->pub_key); do_bn_print_name(out, "Y",dsa->pub_key);
fputs(RESP_EOL, out); fputs(RESP_EOL, out);
} }
if (dsa) FIPS_dsa_free(dsa);
FIPS_dsa_free(dsa);
} }
} }
} }