2016-03-17 22:14:30 +08:00
|
|
|
/*
|
|
|
|
* Copyright 2016 The OpenSSL Project Authors. All Rights Reserved.
|
|
|
|
*
|
2016-05-18 02:20:24 +08:00
|
|
|
* Licensed under the OpenSSL license (the "License"). You may not use
|
|
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
|
|
* in the file LICENSE in the source distribution or at
|
2016-03-17 22:14:30 +08:00
|
|
|
* https://www.openssl.org/source/license.html
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <string.h>
|
|
|
|
|
|
|
|
#include <openssl/e_os2.h>
|
|
|
|
#include <openssl/crypto.h>
|
|
|
|
|
|
|
|
#include "e_os.h"
|
|
|
|
#include "ssl_test_ctx.h"
|
|
|
|
|
|
|
|
/* True enums and other test configuration values that map to an int. */
|
|
|
|
typedef struct {
|
|
|
|
const char *name;
|
|
|
|
int value;
|
|
|
|
} test_enum;
|
|
|
|
|
|
|
|
|
|
|
|
__owur static int parse_enum(const test_enum *enums, size_t num_enums,
|
|
|
|
int *value, const char *name)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
for (i = 0; i < num_enums; i++) {
|
|
|
|
if (strcmp(enums[i].name, name) == 0) {
|
|
|
|
*value = enums[i].value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char *enum_name(const test_enum *enums, size_t num_enums,
|
|
|
|
int value)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
for (i = 0; i < num_enums; i++) {
|
|
|
|
if (enums[i].value == value) {
|
|
|
|
return enums[i].name;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return "InvalidValue";
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*******************/
|
|
|
|
/* ExpectedResult. */
|
|
|
|
/*******************/
|
|
|
|
|
|
|
|
static const test_enum ssl_test_results[] = {
|
|
|
|
{"Success", SSL_TEST_SUCCESS},
|
|
|
|
{"ServerFail", SSL_TEST_SERVER_FAIL},
|
|
|
|
{"ClientFail", SSL_TEST_CLIENT_FAIL},
|
|
|
|
{"InternalError", SSL_TEST_INTERNAL_ERROR},
|
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_expected_result(SSL_TEST_CTX *test_ctx, const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_test_results, OSSL_NELEM(ssl_test_results),
|
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->expected_result = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2016-04-08 01:07:50 +08:00
|
|
|
const char *ssl_test_result_name(ssl_test_result_t result)
|
2016-03-17 22:14:30 +08:00
|
|
|
{
|
|
|
|
return enum_name(ssl_test_results, OSSL_NELEM(ssl_test_results), result);
|
|
|
|
}
|
|
|
|
|
|
|
|
/******************************/
|
|
|
|
/* ClientAlert / ServerAlert. */
|
|
|
|
/******************************/
|
|
|
|
|
|
|
|
static const test_enum ssl_alerts[] = {
|
|
|
|
{"UnknownCA", SSL_AD_UNKNOWN_CA},
|
2016-04-08 01:07:50 +08:00
|
|
|
{"HandshakeFailure", SSL_AD_HANDSHAKE_FAILURE},
|
2016-06-20 23:20:25 +08:00
|
|
|
{"UnrecognizedName", SSL_AD_UNRECOGNIZED_NAME},
|
2016-03-17 22:14:30 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_alert(int *alert, const char *value)
|
|
|
|
{
|
|
|
|
return parse_enum(ssl_alerts, OSSL_NELEM(ssl_alerts), alert, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
__owur static int parse_client_alert(SSL_TEST_CTX *test_ctx, const char *value)
|
|
|
|
{
|
|
|
|
return parse_alert(&test_ctx->client_alert, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
__owur static int parse_server_alert(SSL_TEST_CTX *test_ctx, const char *value)
|
|
|
|
{
|
|
|
|
return parse_alert(&test_ctx->server_alert, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *ssl_alert_name(int alert)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_alerts, OSSL_NELEM(ssl_alerts), alert);
|
|
|
|
}
|
|
|
|
|
|
|
|
/************/
|
|
|
|
/* Protocol */
|
|
|
|
/************/
|
|
|
|
|
|
|
|
static const test_enum ssl_protocols[] = {
|
|
|
|
{"TLSv1.2", TLS1_2_VERSION},
|
|
|
|
{"TLSv1.1", TLS1_1_VERSION},
|
|
|
|
{"TLSv1", TLS1_VERSION},
|
|
|
|
{"SSLv3", SSL3_VERSION},
|
2016-06-03 23:49:04 +08:00
|
|
|
{"DTLSv1", DTLS1_VERSION},
|
|
|
|
{"DTLSv1.2", DTLS1_2_VERSION},
|
2016-03-17 22:14:30 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_protocol(SSL_TEST_CTX *test_ctx, const char *value)
|
|
|
|
{
|
|
|
|
return parse_enum(ssl_protocols, OSSL_NELEM(ssl_protocols),
|
|
|
|
&test_ctx->protocol, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *ssl_protocol_name(int protocol)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_protocols, OSSL_NELEM(ssl_protocols), protocol);
|
|
|
|
}
|
|
|
|
|
2016-04-08 01:07:50 +08:00
|
|
|
/***********************/
|
|
|
|
/* CertVerifyCallback. */
|
|
|
|
/***********************/
|
|
|
|
|
|
|
|
static const test_enum ssl_verify_callbacks[] = {
|
|
|
|
{"None", SSL_TEST_VERIFY_NONE},
|
|
|
|
{"AcceptAll", SSL_TEST_VERIFY_ACCEPT_ALL},
|
|
|
|
{"RejectAll", SSL_TEST_VERIFY_REJECT_ALL},
|
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_client_verify_callback(SSL_TEST_CTX *test_ctx,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_verify_callbacks, OSSL_NELEM(ssl_verify_callbacks),
|
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->client_verify_callback = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *ssl_verify_callback_name(ssl_verify_callback_t callback)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_verify_callbacks, OSSL_NELEM(ssl_verify_callbacks),
|
|
|
|
callback);
|
|
|
|
}
|
|
|
|
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
/**************/
|
|
|
|
/* ServerName */
|
|
|
|
/**************/
|
|
|
|
|
|
|
|
static const test_enum ssl_servername[] = {
|
2016-06-10 06:39:22 +08:00
|
|
|
{"None", SSL_TEST_SERVERNAME_NONE},
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
{"server1", SSL_TEST_SERVERNAME_SERVER1},
|
|
|
|
{"server2", SSL_TEST_SERVERNAME_SERVER2},
|
2016-06-20 23:20:25 +08:00
|
|
|
{"invalid", SSL_TEST_SERVERNAME_INVALID},
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_servername(SSL_TEST_CTX *test_ctx,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_servername, OSSL_NELEM(ssl_servername),
|
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->servername = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2016-06-20 23:20:25 +08:00
|
|
|
__owur static int parse_expected_servername(SSL_TEST_CTX *test_ctx,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_servername, OSSL_NELEM(ssl_servername),
|
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->expected_servername = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
const char *ssl_servername_name(ssl_servername_t server)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_servername, OSSL_NELEM(ssl_servername),
|
|
|
|
server);
|
|
|
|
}
|
|
|
|
|
2016-06-20 23:20:25 +08:00
|
|
|
/***********************/
|
|
|
|
/* ServerNameCallback. */
|
|
|
|
/***********************/
|
|
|
|
|
|
|
|
static const test_enum ssl_servername_callbacks[] = {
|
|
|
|
{"None", SSL_TEST_SERVERNAME_CB_NONE},
|
|
|
|
{"IgnoreMismatch", SSL_TEST_SERVERNAME_IGNORE_MISMATCH},
|
|
|
|
{"RejectMismatch", SSL_TEST_SERVERNAME_REJECT_MISMATCH},
|
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_servername_callback(SSL_TEST_CTX *test_ctx,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_servername_callbacks,
|
|
|
|
OSSL_NELEM(ssl_servername_callbacks), &ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->servername_callback = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *ssl_servername_callback_name(ssl_servername_callback_t callback)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_servername_callbacks,
|
|
|
|
OSSL_NELEM(ssl_servername_callbacks), callback);
|
|
|
|
}
|
|
|
|
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
/*************************/
|
|
|
|
/* SessionTicketExpected */
|
|
|
|
/*************************/
|
|
|
|
|
2016-06-10 06:39:22 +08:00
|
|
|
static const test_enum ssl_session_ticket[] = {
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
{"Ignore", SSL_TEST_SESSION_TICKET_IGNORE},
|
|
|
|
{"Yes", SSL_TEST_SESSION_TICKET_YES},
|
|
|
|
{"No", SSL_TEST_SESSION_TICKET_NO},
|
|
|
|
{"Broken", SSL_TEST_SESSION_TICKET_BROKEN},
|
|
|
|
};
|
|
|
|
|
2016-06-10 06:39:22 +08:00
|
|
|
__owur static int parse_session_ticket(SSL_TEST_CTX *test_ctx, const char *value)
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
{
|
|
|
|
int ret_value;
|
2016-06-10 06:39:22 +08:00
|
|
|
if (!parse_enum(ssl_session_ticket, OSSL_NELEM(ssl_session_ticket),
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->session_ticket_expected = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2016-06-10 06:39:22 +08:00
|
|
|
const char *ssl_session_ticket_name(ssl_session_ticket_t server)
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
{
|
2016-06-10 06:39:22 +08:00
|
|
|
return enum_name(ssl_session_ticket,
|
|
|
|
OSSL_NELEM(ssl_session_ticket),
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
server);
|
|
|
|
}
|
2016-03-17 22:14:30 +08:00
|
|
|
|
2016-06-03 23:49:04 +08:00
|
|
|
/***********************/
|
|
|
|
/* Method. */
|
|
|
|
/***********************/
|
|
|
|
|
|
|
|
static const test_enum ssl_test_methods[] = {
|
|
|
|
{"TLS", SSL_TEST_METHOD_TLS},
|
|
|
|
{"DTLS", SSL_TEST_METHOD_DTLS},
|
|
|
|
};
|
|
|
|
|
|
|
|
__owur static int parse_test_method(SSL_TEST_CTX *test_ctx, const char *value)
|
|
|
|
{
|
|
|
|
int ret_value;
|
|
|
|
if (!parse_enum(ssl_test_methods, OSSL_NELEM(ssl_test_methods),
|
|
|
|
&ret_value, value)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
test_ctx->method = ret_value;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *ssl_test_method_name(ssl_test_method_t method)
|
|
|
|
{
|
|
|
|
return enum_name(ssl_test_methods, OSSL_NELEM(ssl_test_methods), method);
|
|
|
|
}
|
|
|
|
|
2016-03-17 22:14:30 +08:00
|
|
|
/*************************************************************/
|
|
|
|
/* Known test options and their corresponding parse methods. */
|
|
|
|
/*************************************************************/
|
|
|
|
|
|
|
|
typedef struct {
|
|
|
|
const char *name;
|
|
|
|
int (*parse)(SSL_TEST_CTX *test_ctx, const char *value);
|
|
|
|
} ssl_test_ctx_option;
|
|
|
|
|
|
|
|
static const ssl_test_ctx_option ssl_test_ctx_options[] = {
|
|
|
|
{ "ExpectedResult", &parse_expected_result },
|
|
|
|
{ "ClientAlert", &parse_client_alert },
|
|
|
|
{ "ServerAlert", &parse_server_alert },
|
|
|
|
{ "Protocol", &parse_protocol },
|
2016-04-08 01:07:50 +08:00
|
|
|
{ "ClientVerifyCallback", &parse_client_verify_callback },
|
Fix session ticket and SNI
When session tickets are used, it's possible that SNI might swtich the
SSL_CTX on an SSL. Normally, this is not a problem, because the
initial_ctx/session_ctx are used for all session ticket/id processes.
However, when the SNI callback occurs, it's possible that the callback
may update the options in the SSL from the SSL_CTX, and this could
cause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things
can happen:
1. The session ticket TLSEXT may not be written when the ticket expected
flag is set. The state machine transistions to writing the ticket, and
the client responds with an error as its not expecting a ticket.
2. When creating the session ticket, if the ticket key cb returns 0
the crypto/hmac contexts are not initialized, and the code crashes when
trying to encrypt the session ticket.
To fix 1, if the ticket TLSEXT is not written out, clear the expected
ticket flag.
To fix 2, consider a return of 0 from the ticket key cb a recoverable
error, and write a 0 length ticket and continue. The client-side code
can explicitly handle this case.
Fix these two cases, and add unit test code to validate ticket behavior.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1098)
2016-05-13 06:16:52 +08:00
|
|
|
{ "ServerName", &parse_servername },
|
2016-06-20 23:20:25 +08:00
|
|
|
{ "ExpectedServerName", &parse_expected_servername },
|
|
|
|
{ "ServerNameCallback", &parse_servername_callback },
|
2016-06-10 06:39:22 +08:00
|
|
|
{ "SessionTicketExpected", &parse_session_ticket },
|
2016-06-03 23:49:04 +08:00
|
|
|
{ "Method", &parse_test_method },
|
2016-03-17 22:14:30 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Since these methods are used to create tests, we use OPENSSL_assert liberally
|
|
|
|
* for malloc failures and other internal errors.
|
|
|
|
*/
|
|
|
|
SSL_TEST_CTX *SSL_TEST_CTX_new()
|
|
|
|
{
|
|
|
|
SSL_TEST_CTX *ret;
|
|
|
|
ret = OPENSSL_zalloc(sizeof(*ret));
|
|
|
|
OPENSSL_assert(ret != NULL);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
void SSL_TEST_CTX_free(SSL_TEST_CTX *ctx)
|
|
|
|
{
|
|
|
|
OPENSSL_free(ctx);
|
|
|
|
}
|
|
|
|
|
|
|
|
SSL_TEST_CTX *SSL_TEST_CTX_create(const CONF *conf, const char *test_section)
|
|
|
|
{
|
|
|
|
STACK_OF(CONF_VALUE) *sk_conf;
|
|
|
|
SSL_TEST_CTX *ctx;
|
|
|
|
int i;
|
|
|
|
size_t j;
|
|
|
|
|
|
|
|
sk_conf = NCONF_get_section(conf, test_section);
|
|
|
|
OPENSSL_assert(sk_conf != NULL);
|
|
|
|
|
|
|
|
ctx = SSL_TEST_CTX_new();
|
|
|
|
OPENSSL_assert(ctx != NULL);
|
|
|
|
|
|
|
|
for (i = 0; i < sk_CONF_VALUE_num(sk_conf); i++) {
|
|
|
|
int found = 0;
|
|
|
|
const CONF_VALUE *option = sk_CONF_VALUE_value(sk_conf, i);
|
|
|
|
for (j = 0; j < OSSL_NELEM(ssl_test_ctx_options); j++) {
|
|
|
|
if (strcmp(option->name, ssl_test_ctx_options[j].name) == 0) {
|
|
|
|
if (!ssl_test_ctx_options[j].parse(ctx, option->value)) {
|
|
|
|
fprintf(stderr, "Bad value %s for option %s\n",
|
|
|
|
option->value, option->name);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
found = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!found) {
|
|
|
|
fprintf(stderr, "Unknown test option: %s\n", option->name);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
err:
|
|
|
|
SSL_TEST_CTX_free(ctx);
|
|
|
|
ctx = NULL;
|
|
|
|
done:
|
|
|
|
return ctx;
|
|
|
|
}
|