Lang Yu
19b89c8077
amd/common: fix a typo
...
Fixes: 35f053ba8c
("radv: Fix corrupted mipmap copies on GFX9+")
Signed-off-by: Lang Yu <lang.yu@amd.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22000 >
2023-03-20 20:30:32 +00:00
Konstantin Seurer
deb537de3c
radv/rt: Handle load_constant instructions when inlining shaders
...
Fixes the following tests:
dEQP-VK.ray_query.builtin.rayqueryterminate.ahit.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.ahit.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.call.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.call.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.chit.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.chit.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.miss.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.miss.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.rgen.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.rgen.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.sect.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.sect.triangles,Fail
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8647
Fixes: fda262f
("radv/rt: move Ray Tracing shader creation into separate file")
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22002 >
2023-03-20 19:04:34 +00:00
Mike Blumenkrantz
23cd81686c
zink: further eliminate zs implicit feedback loops for read-only access
...
if all access is read-only then there is no feedback loop
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
a702e5038c
zink: explicitly eliminate feedback loops for unused zsbufs
...
this avoids a GENERAL/FEEDBACK_LOOP layout transition where possible
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
618c3651ff
zink: rename add_implicit_color_feedback_loop()
...
this is used for zs too
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
2d099c46cc
zink: allow zink_is_zsbuf_used() without tc / rp optimizing
...
this info should be up-to-date and usable now in all cases
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
c900b9e35f
zink: don't flag rp layout check on next draw when rp optimizing
...
this will always be a no-op, so save the cpu cycles
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
d6e40b7d54
zink: improve no-oping of write -> readonly zsbuf layouts
...
if descriptor binds exist this will have to change layouts anyway,
so allow readonly since it might be a more compatible layout
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
93d7bde9dc
zink: add a fixup case for readonly zsbuf clears
...
this shouldn't currently be possible to hit, but in the future it may
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
e2e079eef4
zink: track whether the fb zsbuf is readonly
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
1b9e9a54ab
zink: fix dsa state parsing for tc info
...
stencil test implies zs write
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
d8bb8af4f5
zink: track zsbuf info even when rp optimizing is disabled
...
this should allow zsbuf elimination in some cases
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Samuel Pitoiset
d750ad19fd
radv: fix NGG streamout with VS and GPL on GFX11
...
With GPL it's not possible to know the primitive topology when
compiling the pre-rasterization stages. For NGG, we use the maximum
number of vertices per prim and rely on the hardware to ignore the
extra bits for points/lines.
Though, this can't work for NGG streamout because the number of
vertices per prim is used to compute a streamout offset. The only
way to solve this is to pass the number of vertices per prim through
a new user SGPR.
This fixes a bunch of streamout tests with Zink/RADV on GFX11.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21833 >
2023-03-20 17:47:03 +00:00
José Roberto de Souza
491887c9f2
intel: Add TODO about removal of 2Mb alignment in i915
...
Xe kmd don't suffer this yet because it still lacks MTL support.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
96302900aa
anv: Apply memory alignment requirements in Xe kmd
...
Without alignment vm bind will fail and during gem buffer creation
size also need to be aligned otherwise the range in vm bind can be
bigger than allocated size for smem.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
7dc8474c3b
intel: Set mem_alignment in Xe kmd
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
bfc1782ad6
anv: Use intel_device_info memory alignment
...
It was also necessary to initialize mem_alignment in the tests
otherwise vma allocation would fail with stubs.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
2ab3d5f436
intel: Move memory aligment information to intel_device_info
...
This same information is also used in ANV, so intel_device_info is
a better place to have it.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:03 +00:00
Eric Engestrom
12cf314dd8
v3d/ci: add another depthstencil-default_fb-drawpixels-* to the flakes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22026 >
2023-03-20 16:51:18 +00:00
Jarred Davies
220356e083
pvr: Add initial support for VK_FORMAT_S8_UINT
...
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21594 >
2023-03-20 14:47:34 +00:00
Jarred Davies
317a3fe49b
pvr: Select a single aspect format for the texture state of DS image views
...
This change also means the texture state words will be based off of the
image view's format instead of the image's format.
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21594 >
2023-03-20 14:47:34 +00:00
Jarred Davies
26671b5d63
pvr: Add support for multiple emits from EOT program
...
Co-authored-by: Simon Perretta <simon.perretta@imgtec.com>
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Signed-off-by: Simon Perretta <simon.perretta@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Jarred Davies
4162c37d57
pvr: Generate dummy emit for renders without any emits
...
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Jarred Davies
de5258ae2b
pvr: Generate EOT program at runtime
...
Also removes hardcoded EOT program.
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Samuel Pitoiset
0badfd8b20
radv: add helpers for destroying various pipeline types
...
Much cleaner than having a single function for everything.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21894 >
2023-03-20 13:56:32 +00:00
Samuel Pitoiset
abfdc06b01
radv: rename RADV_PIPELINE_LIBRARY to RADV_PIPELINE_RAY_TRACING_LIB
...
This seems more consistent with graphics pipeline libraries and it
avoids any confusion.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21894 >
2023-03-20 13:56:32 +00:00
Collabora's Gfx CI Team
10622ccc73
Uprev Piglit to 60e7f0586bac0cfcfcb5871046e31ca2057a5117
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21640 >
2023-03-20 12:17:20 +00:00
Eric Engestrom
20ba9b9faa
v3dv: use vk_get_physical_device_features
...
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21959 >
2023-03-20 12:00:10 +00:00
Eric Engestrom
d94625d110
v3dv: reorder features as 1.0, 1.1, 1.2, 1.3
...
Easier to follow than 1.0, 1.3, 1.2, 1.1 :)
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21959 >
2023-03-20 12:00:09 +00:00
Eric Engestrom
a0be8597ac
v3dv: use common GetPhysicalDeviceFeatures
...
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21959 >
2023-03-20 12:00:09 +00:00
Eric Engestrom
a7c051b5ac
v3d: fix dirty
bitset being too small to accept V3D_DIRTY_SSBO
...
Many of the `V3D_DIRTY_*` flags are above 32 bits, but for now the only
one used here is V3D_DIRTY_SSBO.
`shader->uniform_dirty_bits`, where `dirty` ends up, is already 64 bits.
Fixes: 45bb8f2957
("broadcom: Add V3D 3.3 gallium driver called "vc5", for BCM7268.")
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22019 >
2023-03-20 09:29:40 +00:00
Timothy Arceri
29c71b8eb0
util/00-mesa-defaults: add Akka Arrh workaround
...
Cc: mesa-stable
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21979 >
2023-03-20 07:18:41 +00:00
volodymyr.o
47e7b49c61
mesa ctx->API --> _mesa_is_foo(ctx)
...
replaces direct API checks with _mesa_is_...() checks
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8340
Signed-off-by: Volodymyr Obohzyn volodymyr.obozhyn@globallogic.com
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21556 >
2023-03-20 06:39:57 +00:00
Brian Paul
5e039dbf8e
gallium/xlib: call fence_finish() in XMesaSwapBuffers()
...
Before we can present the buffer we need to wait for the fence to
finish. This fixes severe flickering of unfinished rendering in
many demos/tests. This has been broken for a while, I think.
Note, this is for the non-DRI / Xlib-based GLX.
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21993 >
2023-03-20 06:05:47 +00:00
Oleksii Bozhenko
bbde684ca0
ci: Uprev Piglit
...
Signed-off-by: Oleksii Bozhenko <oleksii.bozhenko@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21810 >
2023-03-20 04:19:23 +00:00
Oleksii Bozhenko
bf910c94e0
glsl: fix gl_CullDistance lowering from float[8] to vec4[2]
...
Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7152
Fixes: ad355652c2
("glsl: Extend lowering pass for gl_ClipDistance to support other arrays")
Signed-off-by: Oleksii Bozhenko oleksii.bozhenko@globallogic.com
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21810 >
2023-03-20 04:19:23 +00:00
Mike Blumenkrantz
ec31535ce0
zink: add debug markers for draws
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21962 >
2023-03-20 03:57:32 +00:00
Mike Blumenkrantz
af9bffd07d
zink: catch zs u_blitter ops for draw markers
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21962 >
2023-03-20 03:57:32 +00:00
Mike Blumenkrantz
c56b46638c
zink: round geometry for u_blitter debug markers
...
this otherwise gets weird values
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21962 >
2023-03-20 03:57:32 +00:00
Mike Blumenkrantz
3a9f7d7038
zink: implement unordered u_blitter calls
...
as long as a few bits of state are swapped around and none of the "main"
cmdbuf state is applied, it becomes possible to promote the entire
u_blitter operation to the unordered cmdbuf and execute it there as
a "transfer" operation that can continue to enable further reordering
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
4593f335f6
zink: add zink_context::unordered_blitting to preserve unordered flags
...
not currently used but will be used to wrap u_blitter
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
887f72990e
zink: split out pipeline rp info update function
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
9746e7253e
zink: manually apply barriers whenever zink_context::blitting is set
...
this simplifies some codepaths at runtime by short-circuiting some
of the more complex operations since it's already known in advance
exactly which images will be used for which purpose
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
07a5ede65a
zink: reset fb clears using the clears_enabled mask
...
iterating was fine before, but it will become problematic to reset
all the clears once they start being stashed for unordered ops
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
7411264ca6
zink: add a dynamic render version of clear_texture hook
...
this avoids the (sizable) overhead of going through the previous path
with set_frame_buffer state et al, instead just firing off a quick
begin+end rendering with a clear
it's also easily reorderable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
e1621d3e6d
zink: add a function for applying u_blitter barriers
...
this handles transitions for a sampler_view src -> framebuffer dst
operation
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
22fb4578a0
zink: end rp earlier in set_framebuffer_state
...
this way any barriers occuring from unbinds won't have to do rp calc
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:20 +00:00
Mike Blumenkrantz
63f425c7d2
zink: double check layouts for possible feedback loop images
...
if a feedback loop hasn't yet been added for an image with both
descriptor and fb binds, queue a check for that to avoid mismatch
affects godot-tps-gles3-high.trace
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:19 +00:00
Mike Blumenkrantz
7812f3844b
zink: add some asserts for zs layout in dynamic render
...
assert all the things
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21906 >
2023-03-20 02:26:19 +00:00
David Heidelberg
dc34413f43
meson: implement quirk for the compilation under armv7 GCC with LTO
...
Until https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108163 gets fixed.
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21554 >
2023-03-19 15:21:22 +00:00