From c631f1d1b6861a8c08603586ded3713d5e84774b Mon Sep 17 00:00:00 2001 From: Chia-I Wu Date: Tue, 19 Nov 2024 10:04:18 -0800 Subject: [PATCH] ci: update the comment on MESA_VK_ABORT_ON_DEVICE_LOSS deqp-runner version is 0.20.2 already. But we would like to keep MESA_VK_ABORT_ON_DEVICE_LOSS globally because, without it, after the first VK_ERROR_DEVICE_LOST in a test group, the error is sticky and the remaining tests will be considered failed as well. deqp-vk gained --deqp-terminate-on-device-lost since 1.3.8.0 and enabled it by default since 1.3.10.0. But let's prefer our own mechanism. Signed-off-by: Chia-I Wu Part-of: --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c63c982350e..906deb52287 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -92,7 +92,7 @@ variables: ARTIFACTS_BASE_URL: https://${CI_PROJECT_ROOT_NAMESPACE}.${CI_PAGES_DOMAIN}/-/${CI_PROJECT_NAME}/-/jobs/${CI_JOB_ID}/artifacts # Python scripts for structured logger PYTHONPATH: "$PYTHONPATH:$CI_PROJECT_DIR/install" - # Drop once deqp-runner is upgraded to > 0.18.0 + # No point in continuing once the device is lost MESA_VK_ABORT_ON_DEVICE_LOSS: 1 # Avoid the wall of "Unsupported SPIR-V capability" warnings in CI job log, hiding away useful output MESA_SPIRV_LOG_LEVEL: error