ci: Avoid subshell for executing HWCI_TEST_SCRIPT

Ensure that $HWCI_TEST_SCRIPT is an executable we can run ourselves, and
run that directly instead of invoking a subshell.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31110>

.gitlab-ci/common/generate-env.sh

@@ -64,6 +64,7 @@ VARS=(
     HWCI_KVM
     HWCI_START_WESTON
     HWCI_START_XORG
+    HWCI_TEST_ARGS
     HWCI_TEST_SCRIPT
     IR3_SHADER_DEBUG
     JOB_ARTIFACTS_BASE

.gitlab-ci/common/init-stage2.sh

@@ -201,7 +201,7 @@ if [ -n "$HWCI_START_WESTON" ]; then
 fi
 
 set +e
-bash -c ". $SCRIPTS_DIR/setup-test-env.sh && $HWCI_TEST_SCRIPT"
+$HWCI_TEST_SCRIPT ${HWCI_TEST_ARGS:-}
 EXIT_CODE=$?
 set -e
 

.gitlab-ci/crosvm-runner.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
 # shellcheck disable=SC2086 # we want word splitting
+
 set -e
 
 # Instead of starting one dEQP instance per available CPU core, pour our

.gitlab-ci/run-shellcheck.sh

@@ -1,6 +1,7 @@
 #!/usr/bin/env bash
 
 CHECKPATH=".gitlab-ci"
+export SCRIPTS_DIR="${CHECKPATH}"
 
 is_bash() {
     [[ $1 == *.sh ]] && return 0

src/gallium/drivers/virgl/ci/gitlab-ci-inc.yml

@@ -71,7 +71,8 @@
   variables:
     HWCI_KERNEL_MODULES: vhost_vsock
     HWCI_KVM: "true"
-    HWCI_TEST_SCRIPT: "/install/crosvm-runner.sh /install/piglit/piglit-traces.sh"
+    HWCI_TEST_SCRIPT: "/install/crosvm-runner.sh"
+    HWCI_TEST_ARGS: "/install/piglit/piglit-traces.sh"
     PARALLELISE_VIA_LP_THREADS: 1
     GPU_VERSION: virgl
     DRIVER_NAME: virgl