Commit Graph

1638 Commits

Author SHA1 Message Date
Alexey Tourbin
ab06ef97bb lz4.h: clarify the risks of using LZ4_decompress_fast()
The notes about "security guarantee" and "malicious inputs" seemed
a bit non-technical to me, so I took the liberty to tone them down
and instead describe the actual risks in technical terms.  Namely,
the function never writes past the end of the output buffer, so
a direct hostile takeover (resulting in arbitrary code execution
soon after the return from the function) is not possible.  However,
the application can crash because of reads from unmapped pages.

I also took the liberty to describe what I believe is the only sensible
usage scenario for the function: "This function is only usable if the
originalSize of uncompressed data is known in advance," etc.
2018-04-23 02:13:49 +03:00
Yann Collet
62d7cdcc74
Merge pull request #503 from lz4/l120
minor length reduction of several large lines
2018-04-19 11:50:20 -07:00
Yann Collet
dede47f13b
Merge pull request #502 from lhacc1/dev
Wrap likely/unlikely macroses with #ifndef
2018-04-19 10:52:48 -07:00
Yann Collet
46058d71aa modified indentation for consistency 2018-04-19 10:50:40 -07:00
Yann Collet
4785bd6a35 minor length reduction of several large lines 2018-04-18 16:49:27 -07:00
Yann Collet
c6301479c5
Merge pull request #497 from lz4/lowAddr
Compatibility with low memory addresses
2018-04-18 10:16:25 -07:00
Dmitrii Rodionov
ea6ed46fc2 Wrap likely/unlikely macroses with #ifndef
It prevent redefine error when project using lz4 has its own likely/unlikely
macroses.
2018-04-18 12:20:56 +03:00
Yann Collet
5ad4599c5a fixed LZ4_compress_fast_extState_fastReset() in 32-bit mode 2018-04-17 16:47:56 -07:00
Yann Collet
88cca1723e fix dictDelta setting error
wrong test
2018-04-17 16:18:37 -07:00
Yann Collet
1520642183 fix matchIndex overflow
can happen with dictCtx
2018-04-17 15:29:17 -07:00
Yann Collet
ce78d10c1f Merge branch 'dev' into lowAddr 2018-04-17 12:07:22 -07:00
Yann Collet
a35aba6d74
Merge pull request #501 from felixhandte/fix-dict-load-offset
Always Bump Offset by 64 KB in LZ4_loadDict()
2018-04-17 12:06:44 -07:00
W. Felix Handte
aedc447804 Always Bump Offset by 64 KB in LZ4_loadDict()
This actually ensures the guarantee referred to in the comment in
LZ4_compress_fast_continue().
2018-04-17 14:09:00 -04:00
Yann Collet
da3b5ba6f0 fixed dictCtx compression 2018-04-16 23:59:42 -07:00
Yann Collet
444211d259 edited a few traces for debugging 2018-04-16 17:16:08 -07:00
Yann Collet
a3aeb34184 fixed minor format warnings 2018-04-16 16:54:03 -07:00
Yann Collet
4aff9b10b5 fixed fuzzer tests
which were modified in parallel within branc `dev`
2018-04-16 16:14:28 -07:00
Yann Collet
b5528ac86c Merge branch 'dev' into lowAddr 2018-04-16 16:12:38 -07:00
Yann Collet
e928064797 fixed gcc performance regression 2018-04-16 15:11:28 -07:00
Yann Collet
2cb9c9034a
Merge pull request #499 from felixhandte/lz4-attach-dict-tests
Test LZ4_attach_dictionary() and Friends
2018-04-13 13:22:38 -07:00
W. Felix Handte
9f0f6b89bb Further Test that ExtDictCtx Mode Produces the Exact Same Output 2018-04-13 11:50:52 -04:00
W. Felix Handte
6dd64e0776 Add Tests for LZ4_attach_dictionary and Friends 2018-04-13 11:50:52 -04:00
Yann Collet
d2bcfa31f5 fixed minor unused variable warning 2018-04-13 02:45:32 -07:00
Yann Collet
c40bac31d3 added comment on variables required after _next_match 2018-04-13 02:26:14 -07:00
Yann Collet
54ec83ce1f fixed potential ptrdiff_t overflow (32-bits mode)
Also removed pointer comparison, which should solve #485
2018-04-13 02:10:53 -07:00
Cyan4973
57afa36795 compatibility with gcc-4.4 string.h version
Someone found it would be a great idea to define there a global variable under the very generic name "index".
Cause problem with shadow warnings, so no variable can be named "index" now ...

Also : automatically update API manual
2018-04-13 01:01:54 -07:00
Cyan4973
98811d6068 added sudo rights for low-mem-address tests 2018-04-13 00:59:27 -07:00
test4973
db9aa785c5 fixed : counting matches which overlap extDict and prefix 2018-04-12 16:12:21 -07:00
test4973
8af32ce6f7 modified a few traces for debug 2018-04-12 13:35:19 -07:00
Yann Collet
27f52724dc
Merge pull request #496 from lz4/circleci
Reduced LZ4 test time on circle-ci
2018-04-12 13:23:51 -07:00
Yann Collet
d6d9bccd53 modified versionsTest
to use MOREFLAGS rather CPPFLAGS
as some older versions of LZ4 overwrite CPPFLAGS environment variable.
2018-04-12 06:47:27 -07:00
test4973
1838803948 fixed LZ4_compress_fast_extState_fastReset() 2018-04-11 16:49:40 -07:00
test4973
b183066793 Merge branch 'dev' into lowAddr 2018-04-11 16:45:19 -07:00
Yann Collet
ca388790e6 allow system-defined CPPFLAGS in /tests 2018-04-11 16:41:25 -07:00
Yann Collet
7b3cd10579 reduced test time on circle-ci 2018-04-11 16:31:43 -07:00
Yann Collet
7b0df7cf49
Merge pull request #492 from felixhandte/avoid-prepare-in-continue
Several Changes Concerning Table Preparation in LZ4 Fast
2018-04-11 16:15:42 -07:00
W. Felix Handte
056ea63215 Fix Silly Warning (const-ness in declaration has no effect on value types!) 2018-04-11 18:42:09 -04:00
W. Felix Handte
51a56c47c0 Minor Fixes 2018-04-11 18:06:48 -04:00
W. Felix Handte
3a0c571272 Add a LZ4_STATIC_LINKING_ONLY Macro to Guard Experimental APIs 2018-04-11 18:06:10 -04:00
W. Felix Handte
afa52c9b95 Expose dictCtx Functionality in LZ4 2018-04-11 16:28:56 -04:00
W. Felix Handte
21f0c9700b Rename _extState_noReset -> _extState_fastReset and Edit Comments 2018-04-11 15:13:01 -04:00
W. Felix Handte
c18bff933b Remove Extraneous Assignment (clearedTable == 0) 2018-04-11 15:12:34 -04:00
W. Felix Handte
59c7d95121 Expose a Faster Stream Reset Function 2018-04-10 13:26:17 -04:00
test4973
ad7e040384 fix minor conversion warning
cast from void not implicit for C++
2018-04-09 20:38:00 -07:00
test4973
cf2f06a6c5 fixed minor conversion warning
ptr diff -> U32
2018-04-09 17:08:17 -07:00
test4973
b28abb9f18 Merge branch 'dev' into lowAddr 2018-04-09 16:23:39 -07:00
W. Felix Handte
f88dc90055 Avoid Calling LZ4_prepareTable() in LZ4_compress_fast_continue() 2018-04-09 16:17:33 -04:00
Yann Collet
c7b17be938
Merge pull request #494 from felixhandte/kill-goto
Return to Allowing Early Returns in LZ4_compress_generic()
2018-04-06 17:35:45 -07:00
W. Felix Handte
5622c276e1 Return to Allowing Early Returns in LZ4_compress_generic()
Or: `goto` Considered Harmful

Or: https://xkcd.com/292/
2018-04-06 19:28:08 -04:00
Yann Collet
158c5840e4
Merge pull request #493 from lz4/statusLine
fixed DISPLAYUPDATE()
2018-04-06 15:33:28 -07:00