mirrors/libfuse
0
0
Fork 0
mirror of https://github.com/libfuse/libfuse.git synced 2024-11-26 21:54:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

fusermount: Close file descriptors with close_range() if possible

Browse Source 
close_range() is much more efficient.

Also remove the lower limit of 3 and set it to 0, as 0 to 1
might have been closed by the application and might be valid.
This commit is contained in:
Bernd Schubert 2024-09-13 20:43:33 +02:00 committed by Bernd Schubert
parent 5f137f01c1
commit 3fe1b25d51
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
util/fusermount.c
View File

@ -1456,8 +1456,33 @@ static void show_version(void)
static void close_inherited_fds(int cfd)
{
int max_fd = sysconf(_SC_OPEN_MAX);
int rc;
for (int fd = 3; fd <= max_fd; fd++) {
#ifdef CLOSE_RANGE_CLOEXEC
/* high range first to be able to log errors through stdout/err*/
rc = close_range(cfd + 1, ~0U, 0);
if (rc < 0) {
fprintf(stderr, "Failed to close high range of FDs: %s",
strerror(errno));
goto fallback;
}
rc = close_range(0, cfd - 1, 0);
if (rc < 0) {
fprintf(stderr, "Failed to close low range of FDs: %s",
strerror(errno));
goto fallback;
}
#endif
fallback:
/*
* This also needs to close stdout/stderr, as the application
* using libfuse might have closed these FDs and might be using
* it. Although issue is now that logging errors won't be possible
* after that.
*/
for (int fd = 0; fd <= max_fd; fd++) {
if (fd != cfd)
close(fd);
}