mirrors/libfuse
0
0
Fork 0
mirror of https://github.com/libfuse/libfuse.git synced 2024-11-23 20:24:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

add error checking to setuid calls (#66)

Browse Source
This commit is contained in:
Alex Richman 2016-07-21 16:17:40 +01:00 committed by Nikolaus Rath
parent 81370fcdc2
commit 1bec2c1a54
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/mount_util.c
View File

@ -100,7 +100,13 @@ static int add_mount(const char *progname, const char *fsname,
char *env = NULL;
sigprocmask(SIG_SETMASK, &oldmask, NULL);
setuid(geteuid());
if(setuid(geteuid()) == -1) {
fprintf(stderr, "%s: setuid: %s\n", progname, strerror(errno));
res = -1;
goto out_restore;
}
execle("/bin/mount", "/bin/mount", "--no-canonicalize", "-i",
"-f", "-t", type, "-o", opts, fsname, mnt, NULL, &env);
fprintf(stderr, "%s: failed to execute /bin/mount: %s\n",
@ -153,7 +159,13 @@ static int exec_umount(const char *progname, const char *rel_mnt, int lazy)
char *env = NULL;
sigprocmask(SIG_SETMASK, &oldmask, NULL);
setuid(geteuid());
if(setuid(geteuid()) == -1) {
fprintf(stderr, "%s: setuid: %s\n", progname, strerror(errno));
res = -1;
goto out_restore;
}
if (lazy) {
execle("/bin/umount", "/bin/umount", "-i", rel_mnt,
"-l", NULL, &env);
@ -219,7 +231,13 @@ static int remove_mount(const char *progname, const char *mnt)
char *env = NULL;
sigprocmask(SIG_SETMASK, &oldmask, NULL);
setuid(geteuid());
if(setuid(geteuid()) == -1) {
fprintf(stderr, "%s: setuid: %s\n", progname, strerror(errno));
res = -1;
goto out_restore;
}
execle("/bin/umount", "/bin/umount", "--no-canonicalize", "-i",
"--fake", mnt, NULL, &env);
fprintf(stderr, "%s: failed to execute /bin/umount: %s\n",