mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-27 03:33:33 +08:00
d40ac01cbb
The recursive lock used on abort does not synchronize with a new process
creation (either by fork-like interfaces or posix_spawn ones), nor it
is reinitialized after fork().
Also, the SIGABRT unblock before raise() shows another race condition,
where a fork or posix_spawn() call by another thread, just after the
recursive lock release and before the SIGABRT signal, might create
programs with a non-expected signal mask. With the default option
(without POSIX_SPAWN_SETSIGDEF), the process can see SIG_DFL for
SIGABRT, where it should be SIG_IGN.
To fix the AS-safe, raise() does not change the process signal mask,
and an AS-safe lock is used if a SIGABRT is installed or the process
is blocked or ignored. With the signal mask change removal,
there is no need to use a recursive loc. The lock is also taken on
both _Fork() and posix_spawn(), to avoid the spawn process to see the
abort handler as SIG_DFL.
A read-write lock is used to avoid serialize _Fork and posix_spawn
execution. Both sigaction (SIGABRT) and abort() requires to lock
as writer (since both change the disposition).
The fallback is also simplified: there is no need to use a loop of
ABORT_INSTRUCTION after _exit() (if the syscall does not terminate the
process, the system is broken).
The proposed fix changes how setjmp works on a SIGABRT handler, where
glibc does not save the signal mask. So usage like the below will now
always abort.
static volatile int chk_fail_ok;
static jmp_buf chk_fail_buf;
static void
handler (int sig)
{
if (chk_fail_ok)
{
chk_fail_ok = 0;
longjmp (chk_fail_buf, 1);
}
else
_exit (127);
}
[...]
signal (SIGABRT, handler);
[....]
chk_fail_ok = 1;
if (! setjmp (chk_fail_buf))
{
// Something that can calls abort, like a failed fortify function.
chk_fail_ok = 0;
printf ("FAIL\n");
}
Such cases will need to use sigsetjmp instead.
The _dl_start_profile calls sigaction through _profil, and to avoid
pulling abort() on loader the call is replaced with __libc_sigaction.
Checked on x86_64-linux-gnu and aarch64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
119 lines
4.8 KiB
C
119 lines
4.8 KiB
C
/* Declarations of internal pthread functions used by libc. Hurd version.
|
|
Copyright (C) 2016-2024 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef _PTHREADP_H
|
|
#define _PTHREADP_H 1
|
|
|
|
#define __PTHREAD_HTL
|
|
|
|
#include <pthread.h>
|
|
#include <link.h>
|
|
|
|
/* Attribute to indicate thread creation was issued from C11 thrd_create. */
|
|
#define ATTR_C11_THREAD ((void*)(uintptr_t)-1)
|
|
|
|
extern void __pthread_init_static_tls (struct link_map *) attribute_hidden;
|
|
|
|
/* These represent the interface used by glibc itself. */
|
|
|
|
extern int __pthread_mutex_init (pthread_mutex_t *__mutex, const pthread_mutexattr_t *__attr);
|
|
extern int __pthread_mutex_destroy (pthread_mutex_t *__mutex);
|
|
extern int __pthread_mutex_lock (pthread_mutex_t *__mutex);
|
|
extern int __pthread_mutex_trylock (pthread_mutex_t *_mutex);
|
|
extern int __pthread_mutex_timedlock (pthread_mutex_t *__mutex,
|
|
const struct timespec *__abstime);
|
|
extern int __pthread_mutex_unlock (pthread_mutex_t *__mutex);
|
|
extern int __pthread_mutexattr_init (pthread_mutexattr_t *attr);
|
|
extern int __pthread_mutexattr_settype (pthread_mutexattr_t *attr, int kind);
|
|
|
|
extern int __pthread_cond_init (pthread_cond_t *cond,
|
|
const pthread_condattr_t *cond_attr);
|
|
extern int __pthread_cond_signal (pthread_cond_t *cond);
|
|
extern int __pthread_cond_broadcast (pthread_cond_t *cond);
|
|
extern int __pthread_cond_wait (pthread_cond_t *cond, pthread_mutex_t *mutex);
|
|
extern int __pthread_cond_timedwait (pthread_cond_t *cond,
|
|
pthread_mutex_t *mutex,
|
|
const struct timespec *abstime);
|
|
extern int __pthread_cond_clockwait (pthread_cond_t *cond,
|
|
pthread_mutex_t *mutex,
|
|
clockid_t clockid,
|
|
const struct timespec *abstime)
|
|
__nonnull ((1, 2, 4));
|
|
extern int __pthread_cond_destroy (pthread_cond_t *cond);
|
|
|
|
typedef struct __cthread *__cthread_t;
|
|
typedef int __cthread_key_t;
|
|
typedef void * (*__cthread_fn_t)(void *__arg);
|
|
|
|
__cthread_t __cthread_fork (__cthread_fn_t, void *);
|
|
int __pthread_create (pthread_t *newthread,
|
|
const pthread_attr_t *attr,
|
|
void *(*start_routine) (void *), void *arg);
|
|
|
|
void __cthread_detach (__cthread_t);
|
|
int __pthread_detach (pthread_t __threadp);
|
|
void __pthread_exit (void *value) __attribute__ ((__noreturn__));
|
|
int __pthread_join (pthread_t, void **);
|
|
int __cthread_keycreate (__cthread_key_t *);
|
|
int __cthread_getspecific (__cthread_key_t, void **);
|
|
int __cthread_setspecific (__cthread_key_t, void *);
|
|
int __pthread_key_create (pthread_key_t *key, void (*destr) (void *));
|
|
void *__pthread_getspecific (pthread_key_t key);
|
|
int __pthread_setspecific (pthread_key_t key, const void *value);
|
|
int __pthread_key_delete (pthread_key_t key);
|
|
int __pthread_once (pthread_once_t *once_control, void (*init_routine) (void));
|
|
|
|
int __pthread_setcancelstate (int state, int *oldstate);
|
|
|
|
int __pthread_getattr_np (pthread_t, pthread_attr_t *);
|
|
int __pthread_attr_getstackaddr (const pthread_attr_t *__restrict __attr,
|
|
void **__restrict __stackaddr);
|
|
int __pthread_attr_setstackaddr (pthread_attr_t *__attr, void *__stackaddr);
|
|
int __pthread_attr_getstacksize (const pthread_attr_t *__restrict __attr,
|
|
size_t *__restrict __stacksize);
|
|
int __pthread_attr_setstacksize (pthread_attr_t *__attr, size_t __stacksize);
|
|
int __pthread_attr_setstack (pthread_attr_t *__attr, void *__stackaddr,
|
|
size_t __stacksize);
|
|
int __pthread_attr_getstack (const pthread_attr_t *, void **, size_t *);
|
|
void __pthread_testcancel (void);
|
|
|
|
#define __pthread_raise_internal(__sig) raise (__sig)
|
|
|
|
libc_hidden_proto (__pthread_self)
|
|
|
|
#if IS_IN (libpthread)
|
|
hidden_proto (__pthread_create)
|
|
hidden_proto (__pthread_detach)
|
|
hidden_proto (__pthread_key_create)
|
|
hidden_proto (__pthread_getspecific)
|
|
hidden_proto (__pthread_setspecific)
|
|
hidden_proto (__pthread_mutex_init)
|
|
hidden_proto (__pthread_mutex_destroy)
|
|
hidden_proto (__pthread_mutex_lock)
|
|
hidden_proto (__pthread_mutex_trylock)
|
|
hidden_proto (__pthread_mutex_unlock)
|
|
hidden_proto (__pthread_mutex_timedlock)
|
|
hidden_proto (__pthread_get_cleanup_stack)
|
|
#endif
|
|
|
|
#define ASSERT_TYPE_SIZE(type, size) \
|
|
_Static_assert (sizeof (type) == size, \
|
|
"sizeof (" #type ") != " #size)
|
|
|
|
#endif /* pthreadP.h */
|