glibc/resolv
Florian Weimer a1a20f0292 resolv: Fix file handle leak in __resolv_conf_load [BZ #25429]
res_vinit_1 did not close the stream on errors, only on success.
This change moves closing the stream to __resolv_conf_load, for both
the success and error cases.

Fixes commit 89f187a40f ("resolv: Use
getline for configuration file reading in res_vinit_1") and commit
3f853f22c8 ("resolv: Lift domain search
list limits [BZ #19569] [BZ #21475]"), where memory allocation was
introduced into res_vinit_1.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2020-02-14 08:13:58 +01:00
..
arpa Update DNS RR type definitions [BZ #20593] 2016-12-31 21:16:27 +01:00
bits/types resolv: Introduce struct resolv_conf with extended resolver state 2017-07-03 20:57:28 +02:00
nss_dns nss_dns: Use NSS_DECLARE_MODULE_FUNCTIONS 2020-02-13 09:14:58 +01:00
rpc Install a dummy <rpc/netdb.h> when not building sunrpc/. 2015-07-08 13:38:50 -07:00
sys
base64.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
compat-gethnamaddr.c resolv: Remove debugging code from compat-gethnamaddr.c 2019-02-18 16:39:15 +01:00
compat-hooks.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Depend hurd: Add hurd thread library 2018-04-02 01:44:14 +02:00
gai_cancel.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_error.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_misc.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_misc.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_notify.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_sigqueue.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gai_suspend.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
getaddrinfo_a.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
herror.c Consolidate non cancellable writev call 2017-08-21 15:37:45 -03:00
inet_addr.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
inet_net_ntop.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
inet_net_pton.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
inet_neta.c Consistently use uintN_t not u_intN_t everywhere. 2017-08-07 19:55:34 +00:00
inet_ntop.c resolv: Remove internal_function attribute 2017-08-31 16:07:52 +02:00
inet_pton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
mapv4v6addr.h . 2007-07-31 13:33:18 +00:00
mapv4v6hostent.h Handle running out of buffer space with IPv6 mapping enabled. 2009-11-10 07:36:50 -08:00
netdb.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
ns_date.c Consistently use uintN_t not u_intN_t everywhere. 2017-08-07 19:55:34 +00:00
ns_name.c resolv: ns_name_pton should report trailing \ as error [BZ #22413] 2017-11-11 11:41:45 +01:00
ns_netint.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
ns_parse.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
ns_print.c Obsolete p_secstodate. 2017-11-22 22:21:10 +00:00
ns_samedomain.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
ns_ttl.c Add fall-through comments. 2019-02-12 10:30:34 +00:00
nsap_addr.c resolv: Remove SCCS and RCS keywords 2016-04-28 12:53:49 +02:00
README resolv: Remove unused resolv/res_debug.h header file 2017-06-30 11:31:29 +02:00
res_comp.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_data.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_debug.c resolv: Implement trust-ad option for /etc/resolv.conf [BZ #20358] 2019-11-27 20:54:37 +01:00
res_enable_icmp.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_hconf.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_hconf.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_init.c resolv: Fix file handle leak in __resolv_conf_load [BZ #25429] 2020-02-14 08:13:58 +01:00
res_libc.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_mkquery.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_query.c resolv: Lift domain search list limits [BZ #19569] [BZ #21475] 2017-07-03 21:01:42 +02:00
res_randomid.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res_send.c Get rid of Werror=maybe-uninitialized in res_send.c. 2020-01-20 10:57:08 +01:00
res-close.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
res-state.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv_conf.c resolv: Use <file_change_detection.h> in __resolv_conf_get_current 2020-02-14 08:13:39 +01:00
resolv_conf.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv_context.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv_context.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv-internal.h Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv.h resolv: Implement trust-ad option for /etc/resolv.conf [BZ #20358] 2019-11-27 20:54:37 +01:00
tst-aton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-bug18665-tcp.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-bug18665.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-inet_aton_exact.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-inet_ntop.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-inet_pton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-leaks2.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-leaks.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-no-libidn2.c Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247] 2018-05-23 15:27:24 +02:00
tst-ns_name_compress.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-ns_name_pton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-ns_name.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-ns_name.data Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-p_secstodate.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-res_hconf_reorder.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-res_hnok.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-ai_idn-common.c resolv: Fix CNAME chaining in resolv/tst-resolv-ai_idn-common.c 2020-02-07 18:48:04 +01:00
tst-resolv-ai_idn-latin1.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-ai_idn-nolibidn2.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-ai_idn.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-basic.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-binary.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-canonname.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-edns.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-network.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-nondecimal.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-qtypes.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-res_init-multi.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-res_init-skeleton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-res_init-thread.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-res_init.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-res_ninit.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-rotate.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-search.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-threads.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-trailing.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
tst-resolv-trustad.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Versions CVE-2016-10739: getaddrinfo: Fully parse IPv4 address strings [BZ #20018] 2019-01-21 21:26:03 +01:00

The resolver in the GNU C Library
*********************************

Starting with version 2.2, the resolver in the GNU C Library comes
from BIND 8.  Only a subset of the src/lib/resolv part of libbind is
included here; basically the parts that are needed to provide the
functionality present in the resolver from BIND 4.9.7 that was
included in the previous release of the GNU C Library, augmented by
the parts needed to provide thread-safety.  This means that support
for things as dynamic DNS updates and TSIG keys isn't included.  If
you need those facilities, please take a look at the full BIND
distribution.


Differences
===========

The resolver in the GNU C Library still differs from what's in BIND
8.2.3-T5B:

* The RES_DEBUG option (`options debug' in /etc/resolv.conf) has been
  disabled.

* The resolver in glibc allows underscores in domain names.

* The <resolv.h> header in glibc includes <netinet/in.h> and
  <arpa/nameser.h> to make it self-contained.

* The `res_close' function in glibc only tries to close open files
  referenced through `_res' if the RES_INIT bit is set in
  `_res.options'.  This fixes a potential security bug with programs
  that bogusly call `res_close' without initialising the resolver
  state first.  Note that the thread-safe `res_nclose' still doesn't
  check the RES_INIT bit.  By the way, you're not really supposed to
  call `res_close/res_nclose' directly.

* The resolver in glibc can connect to a nameserver over IPv6.  Just
  specify the IPv6 address in /etc/resolv.conf.  You cannot change the
  address of an IPv6 nameserver dynamically in your program though.


Using the resolver in multi-threaded code
=========================================

The traditional resolver interfaces `res_query', `res_search',
`res_mkquery', `res_send' and `res_init', used a static (global)
resolver state stored in the `_res' structure.  Therefore, these
interfaces are not thread-safe.  Therefore, BIND 8.2 introduced a set
of "new" interfaces `res_nquery', `res_nsearch', `res_nmkquery',
`res_nsend' and `res_ninit' that take a `res_state' as their first
argument, so you can use a per-thread resolver state.  In glibc, when
you link with -lpthread, such a per-thread resolver state is already
present.  It can be accessed using `_res', which has been redefined as
a macro, in a similar way to what has been done for the `errno' and
`h_errno' variables.  This per-thread resolver state is also used for
the `gethostby*' family of functions, which means that for example
`gethostbyname_r' is now fully thread-safe and re-entrant.  The
traditional resolver interfaces however, continue to use a single
resolver state and are therefore still thread-unsafe.  The resolver
state is the same resolver state that is used for the initial ("main")
thread.

This has the following consequences for existing binaries and source
code:

* Single-threaded programs will continue to work.  There should be no
  user-visible changes when you recompile them.

* Multi-threaded programs that use the traditional resolver interfaces
  in the "main" thread should continue to work, except that they no
  longer see any changes in the global resolver state caused by calls
  to, for example, `gethostbyname' in other threads.  Again there
  should be no user-visible changes when you recompile these programs.

* Multi-threaded programs that use the traditional resolver interfaces
  in more than one thread should be just as buggy as before (there are
  no problems if you use proper locking of course).  If you recompile
  these programs, manipulating the _res structure in threads other
  than the "main" thread will seem to have no effect though.

* In Multi-threaded that manipulate the _res structure, calls to
  functions like `gethostbyname' in threads other than the "main"
  thread won't be influenced by the those changes anymore.

We recommend to use the new thread-safe interfaces in new code, since
the traditional interfaces have been deprecated by the BIND folks.
For compatibility with other (older) systems you might want to
continue to use those interfaces though.


Using the resolver in C++ code
==============================

There resolver contains some hooks which will allow the user to
install some callback functions that make it possible to filter DNS
requests and responses.  Although we do not encourage you to make use
of this facility at all, C++ developers should realise that it isn't
safe to throw exceptions from such callback functions.


Source code
===========

The following files come from the BIND distribution (currently version
8.2.3-T5B):

src/include/
  arpa/nameser.h
  arpa/nameser_compat.h
  resolv.h

src/lib/resolv/
  herror.c
  res_comp.c
  res_data.c
  res_debug.c
  res_init.c
  res_mkquery.c
  res_query.c
  res_send.c

src/lib/nameser/
  ns_name.c
  ns_netint.c
  ns_parse.c
  ns_print.c
  ns_samedomain.c
  ns_ttl.c

src/lib/inet/
  inet_addr.c
  inet_net_ntop.c
  inet_net_pton.c
  inet_neta.c
  inet_ntop.c
  inet_pton.c
  nsap_addr.c

src/lib/isc/
  base64.c

Some of these files have been optimised a bit, and adaptations have
been made to make them fit in with the rest of glibc.

res_libc.c is home-brewn, although parts of it are taken from res_data.c.

res_hconf.c and res_hconf.h were contributed by David Mosberger, and
do not come from BIND.

The files gethnamaddr.c, mapv4v6addr.h and mapv4v6hostent.h are
leftovers from BIND 4.9.7.