mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-27 19:53:32 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
7553131847
glibc/sysdeps/unix
History
Joseph Myers 7553131847 Fix struct sigaltstack namespace (bug 21517). 
glibc defines the stack_t type with the tag struct sigaltstack.  This
is not permitted by POSIX; sigaltstack is only reserved with file
scope in the namespace of ordinary identifiers, not the tag namespace,
and in the case where stack_t is obtained from ucontext.h rather than
signal.h, it's not reserved with file scope at all.

This patch removes the tag accordingly and updates uses in glibc of
struct sigaltstack.  This is similar to the removal of the "struct
siginfo" tag a few years ago: C++ name mangling changes are an
unavoidable consequence.  A NEWS item is added to note the changed
mangling.  There is inevitably some risk of breaking builds of
anything that relies on the struct sigaltstack name (though the first
few hits I looked at from codesearch.debian.net generally seemed to
involve code that could use the stack_t name conditionally, so
depending on how they determine the conditionals they may work with
glibc not defining the struct tag anyway).

Tested for x86_64 and x86, and with build-many-glibcs.py.

	[BZ #21517]
	* bits/types/stack_t.h (stack_t): Remove struct tag.
	* sysdeps/unix/sysv/linux/bits/types/stack_t.h (stack_t):
	Likewise.
	* sysdeps/unix/sysv/linux/mips/bits/types/stack_t.h (stack_t):
	Likewise.
	* debug/segfault.c (install_handler): Use stack_t instead of
	struct sigaltstack.
	* hurd/hurd/signal.h (struct hurd_sigstate): Likewise.
	* hurd/trampoline.c (_hurd_setup_sighandler): Likewise.
	* include/signal.h (__sigaltstack): Likwise.
	* signal/sigaltstack.c (__sigaltstack): Likewise.
	* signal/signal.h (sigaltstack): Likewise.
	* sysdeps/mach/hurd/i386/signal-defines.sym
	(SIGALTSTACK__SS_SP__OFFSET): Likewise.
	(SIGALTSTACK__SS_SIZE__OFFSET): Likewise.
	(SIGALTSTACK__SS_FLAGS__OFFSET): Likewise.
	* sysdeps/mach/hurd/sigaltstack.c (__sigaltstack): Likewise.
	* sysdeps/mach/hurd/sigstack.c (sigstack): Likewise.
	* sysdeps/unix/sysv/linux/alpha/sys/procfs.h (struct
	elf_prstatus): Likewise.
	* sysdeps/unix/sysv/linux/hppa/____longjmp_chk.c (CHECK_SP):
	Likewise.
	* sysdeps/unix/sysv/linux/ia64/sys/procfs.h (struct elf_prstatus):
	Likewise.
	* sysdeps/unix/sysv/linux/m68k/____longjmp_chk.c (CHECK_SP):
	Likewise.
	* sysdeps/unix/sysv/linux/powerpc/sys/procfs.h (struct
	elf_prstatus): Likewise.
	* sysdeps/unix/sysv/linux/sh/sys/procfs.h (struct elf_prstatus):
	Likewise.
	* sysdeps/unix/sysv/linux/sys/procfs.h (struct elf_prstatus):
	Likewise.
2017-06-05 10:17:46 +00:00
..
alpha Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
arm Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bsd Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
i386 Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
inet Move nss directory into sysdeps Subdirs. 2013-02-05 14:32:48 -08:00
mips Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
powerpc Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
sh Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
sysv/linux Fix struct sigaltstack namespace (bug 21517). 2017-06-05 10:17:46 +00:00
x86_64 Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
clock_gettime.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
clock_nanosleep.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
clock_settime.c Narrowing the visibility of libc-internal.h even further. 2017-03-01 20:33:46 -05:00
confstr.h
get_child_max.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
getlogin_r.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
getlogin.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
grantpt.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
ifreq.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
Implies
make-syscalls.sh Do not stack-protect ifunc resolvers [BZ #7065] 2016-12-26 10:08:41 +01:00
Makefile Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
s-proto-cancel.S
s-proto.S
setxid.h
sockatmark.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
stime.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
syscall-template.S Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
syscall.S Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
syscalls.list posix: Consolidate Linux fsync syscall 2017-05-18 18:06:47 -03:00
sysdep.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00