mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-30 05:03:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
release/2.37/master
glibc/string
History
Noah Goldstein f82e0922de x86: Fix bug in strchrnul-evex512 [BZ #32078] 
Issue was we were expecting not matches with CHAR before the start of
the string in the page cross case.

The check code in the page cross case:
```
    and    $0xffffffffffffffc0,%rax
    vmovdqa64 (%rax),%zmm17
    vpcmpneqb %zmm17,%zmm16,%k1
    vptestmb %zmm17,%zmm17,%k0{%k1}
    kmovq  %k0,%rax
    inc    %rax
    shr    %cl,%rax
    je     L(continue)
```

expects that all characters that neither match null nor CHAR will be
1s in `rax` prior to the `inc`. Then the `inc` will overflow all of
the 1s where no relevant match was found.

This is incorrect in the page-cross case, as the
`vmovdqa64 (%rax),%zmm17` loads from before the start of the input
string.

If there are matches with CHAR before the start of the string, `rax`
won't properly overflow.

The fix is quite simple. Just replace:

```
    inc    %rax
    shr    %cl,%rax
```
With:
```
    sar    %cl,%rax
    inc    %rax
```

The arithmetic shift will clear any matches prior to the start of the
string while maintaining the signbit so the 1s can properly overflow
to zero in the case of no matches.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

(cherry picked from commit 7da0886247)
2024-08-15 15:42:39 -07:00
..
bits Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
_strerror.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-addsep.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-append.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-count.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-create.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-ctsep.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-delete.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-extract.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-insert.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-next.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-replace.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz-stringify.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
argz.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
basename.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
bcopy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
bug-envz1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
bug-strcoll1.c
bug-strcoll2.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
bug-strncat1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strpbrk1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strspn1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strtok1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
byteswap.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
bzero.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Depend
endian.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
envz.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
envz.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
explicit_bzero.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
ffs.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
ffsll.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
inl-tester.c
Makefile Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memccpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memcmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memcmpeq.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memfrob.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memmem.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memmove.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memory.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
mempcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memrchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memset.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
noinl-tester.c
rawmemchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
sigabbrev_np.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
sigdescr_np.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
stpcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
stpncpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
str-two-way.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
stratcliff.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcasecmp_l.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcasecmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcasestr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcat.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strchrnul.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcoll_l.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcoll.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcspn.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strdup.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strerror_l.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strerror.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strerrordesc_np.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strerrorname_np.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strfry.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
string-inlines.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
string.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strings.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strlen.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strncase_l.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strncase.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strncat.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strncmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strncpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strndup.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strnlen.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strpbrk.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strrchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strsep.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strsignal.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strspn.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strstr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strtok_r.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strtok.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strverscmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strxfrm_l.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strxfrm.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
swab.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-bcopy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-bzero.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-endian-file-scope.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-endian-sign-conversion.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-endian-types.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-explicit_bzero.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-ffs.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memccpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memcmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memcmpeq.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memcpy-large.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memcpy-support.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memmem.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memmove.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-mempcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memrchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-memset.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-rawmemchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-sig_np.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-stpcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-stpncpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcasecmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcasestr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcat.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strchr.c x86: Fix bug in strchrnul-evex512 [BZ #32078] 2024-08-15 15:42:39 -07:00
test-strchrnul.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strcspn.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strerror-errno.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-string.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strlen.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strncasecmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strncat.c x86: Fix strncat-avx2.S reading past length [BZ #30065] 2023-01-31 19:13:46 -06:00
test-strncmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strncpy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strnlen.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strpbrk.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strrchr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strspn.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
test-strstr.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
testcopy.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tester.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-bswap.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-cmp.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-endian.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-inlcall.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-memmove-overflow.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-strcoll-overflow.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-strerror.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-strfry.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strlen.c Use '%z' instead of '%Z' on printf functions 2022-09-22 08:48:04 -03:00
tst-strsignal.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-strtok_r.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
tst-strtok.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.expect * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-svc.input * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-xbzero-opt.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Versions String: Add support for __memcmpeq() ABI on all targets 2021-10-26 16:51:29 -05:00
wordcopy.c string: Suppress -Wmaybe-unitialized for wordcopy [BZ #19444] 2023-01-12 09:06:00 -03:00
xpg-strerror.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00