mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-30 13:13:43 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Let signbit use the builtin in C++ mode with gcc < 6.x (bug 22296)

Browse Source 
When using gcc < 6.x, signbit does not use the type-generic
__builtin_signbit builtin, instead it uses __MATH_TG.
However, when library support for float128 is available, __MATH_TG uses
__builtin_types_compatible_p, which is not available in C++ mode.

On the other hand, libstdc++ undefines (in cmath) many macros from
math.h, including signbit, so that it can provide its own functions.
However, during its configure tests, libstdc++ just tests for the
availability of the macros (it does not undefine them, nor does it
provide its own functions).

Finally, libstdc++ configure tests include math.h and get the definition
of signbit that uses __MATH_TG (and __builtin_types_compatible_p).
Since libstdc++ does not undefine the macros during its configure
tests, they fail.

This patch lets signbit use the builtin in C++ mode when gcc < 6.x is
used. This allows the configure test in libstdc++ to work.

Tested for x86_64.

	[BZ #22296]
	* math/math.h: Let signbit use the builtin in C++ mode with gcc
	< 6.x

Cc: Gabriel F. T. Gomes <gftg@linux.vnet.ibm.com>
Cc: Joseph Myers <joseph@codesourcery.com>
(cherry picked from commit 386e1c26ac)
This commit is contained in:
Romain Naour 2017-10-16 23:21:56 +02:00 committed by Gabriel F. T. Gomes
parent f82a6fc223
commit f8279a4b3c
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2017-10-17 Romain Naour <romain.naour@gmail.com> (tiny change)
[BZ #22296]
* math/math.h: Let signbit use the builtin in C++ mode with gcc
< 6.x
2017-10-22 H.J. Lu <hongjiu.lu@intel.com>
[BZ #21265]

1
NEWS
View File

@ -45,6 +45,7 @@ The following bugs are resolved with this release:
[22146] Let fpclassify use the builtin when optimizing for size in C++ mode
[22225] math: nearbyint arithmetic moved before feholdexcept
[22235] Add C++ versions of iscanonical for ldbl-96 and ldbl-128ibm
[22296] Let signbit use the builtin in C++ mode with gcc < 6.x
[22321] sysconf: Fix missing definition of UIO_MAXIOV on Linux
[22325] glibc: Memory leak in glob with GLOB_TILDE (CVE-2017-15671)

9
math/math.h
View File

@ -418,6 +418,15 @@ enum
/* Return nonzero value if sign of X is negative. */
# if __GNUC_PREREQ (6,0)
# define signbit(x) __builtin_signbit (x)
# elif defined __cplusplus
/* In C++ mode, __MATH_TG cannot be used, because it relies on
__builtin_types_compatible_p, which is a C-only builtin.
The check for __cplusplus allows the use of the builtin instead of
__MATH_TG. This is provided for libstdc++, only to let its configure
test work. No further use of this definition of signbit is expected
in C++ mode, since libstdc++ provides its own version of signbit
in cmath (which undefines signbit). */
# define signbit(x) __builtin_signbitl (x)
# elif __GNUC_PREREQ (4,0)
# define signbit(x) __MATH_TG ((x), __builtin_signbit, (x))
# else