diff --git a/ChangeLog b/ChangeLog index b5727c7585..4b18e27288 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2019-01-02 Florian Weimer + + [BZ #24018] + * intl/dcigettext.c (DCIGETTEXT): Do not return NULL on asprintf + failure. + 2018-12-31 Florian Weimer [BZ #24027] diff --git a/NEWS b/NEWS index ef857b6e6c..49895f81bd 100644 --- a/NEWS +++ b/NEWS @@ -163,6 +163,7 @@ The following bugs are resolved with this release: [23579] libc: Errors misreported in preadv2 [23709] Fix CPU string flags for Haswell-type CPUs [23927] Linux if_nametoindex() does not close descriptor (CVE-2018-19591) + [24018] gettext may return NULL [24027] malloc: Integer overflow in realloc Version 2.26 diff --git a/intl/dcigettext.c b/intl/dcigettext.c index f63b34b0f5..cfcdd304b4 100644 --- a/intl/dcigettext.c +++ b/intl/dcigettext.c @@ -635,7 +635,7 @@ DCIGETTEXT (const char *domainname, const char *msgid1, const char *msgid2, int ret = __asprintf (&xdirname, "%s/%s", cwd, dirname); free (cwd); if (ret < 0) - return NULL; + goto return_untranslated; dirname = xdirname; } #ifndef IN_LIBGLOCALE