mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-27 19:53:32 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update x86 fix-fp-int-compare-invalid.h for GCC 8.

Browse Source 
The glibc implementation of iseqsig relies on ordered comparison
operators raising the "invalid" exception for quiet NaN operands, with
a workaround on platforms where a GCC bug means that exception is not
raised.  For x86, that bug has now been fixed for GCC 8, so this patch
disables the workaround in that case.  If and when the corresponding
bugs for powerpc and s390 are fixed, the headers for those platforms
should of course be updated similarly.

Tested for x86_64 and x86, including with GCC mainline.  Note that
other failures appear with GCC mainline because of spurious use of
ordered comparison instructions for unordered operations
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82692>.

	* sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
	(FIX_COMPARE_INVALID): Define to 0 if [__GNUC_PREREQ (8, 0)].
This commit is contained in:
Joseph Myers 2017-10-24 00:33:08 +00:00
parent aa95a2414e
commit 91c3985c23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-10-24 Joseph Myers <joseph@codesourcery.com>
* sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
(FIX_COMPARE_INVALID): Define to 0 if [__GNUC_PREREQ (8, 0)].
2017-10-23 Adhemerval Zanella <adhemerval.zanella@linaro.org>
* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Use 0 instead of

8
sysdeps/x86/fpu/fix-fp-int-compare-invalid.h
View File

@ -20,9 +20,13 @@
#ifndef FIX_FP_INT_COMPARE_INVALID_H
#define FIX_FP_INT_COMPARE_INVALID_H 1
/* As of GCC 5, both x87 and SSE comparisons use unordered comparison
/* Before GCC 8, both x87 and SSE comparisons use unordered comparison
instructions when they should use ordered comparisons
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52451>. */
#define FIX_COMPARE_INVALID 1
#if __GNUC_PREREQ (8, 0)
# define FIX_COMPARE_INVALID 0
#else
# define FIX_COMPARE_INVALID 1
#endif
#endif /* fix-fp-int-compare-invalid.h */