hurd: Microoptimize _hurd_self_sigstate ()

When THREAD_GETMEM is defined with inline assembly, the compiler may not
optimize away the two reads of _hurd_sigstate. Help it out a little bit
by only reading it once. This also makes for a slightly cleaner code.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230319151017.531737-32-bugaevc@gmail.com>
This commit is contained in:
Sergey Bugaev 2023-03-19 18:10:14 +03:00 committed by Samuel Thibault
parent 17841fa7d4
commit 7b3d8558d9

View File

@ -166,13 +166,15 @@ extern void _hurd_sigstate_delete (thread_t thread);
_HURD_SIGNAL_H_EXTERN_INLINE struct hurd_sigstate * _HURD_SIGNAL_H_EXTERN_INLINE struct hurd_sigstate *
_hurd_self_sigstate (void) _hurd_self_sigstate (void)
{ {
if (THREAD_GETMEM (THREAD_SELF, _hurd_sigstate) == NULL) struct hurd_sigstate *ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate);
if (__glibc_unlikely (ss == NULL))
{ {
thread_t self = __mach_thread_self (); thread_t self = __mach_thread_self ();
THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, _hurd_thread_sigstate (self)); ss = _hurd_thread_sigstate (self);
THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss);
__mach_port_deallocate (__mach_task_self (), self); __mach_port_deallocate (__mach_task_self (), self);
} }
return THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); return ss;
} }
# endif # endif
#endif #endif