From 6af956e5c019637051ba8cfb46cfff9bbe574500 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20=C3=81vila=20de=20Esp=C3=ADndola?= Date: Mon, 3 Dec 2018 20:59:22 +0000 Subject: [PATCH] Enable VDSO for static linking on arm I have tested that this builds and the resulting program still work. The kernel in gcc117 (which I ussed for testing) seems to be missing https://patchwork.kernel.org/patch/10060431/, so the vdso is never used. [BZ #19767] * sysdeps/unix/sysv/linux/arm/init-first.c: Remove #ifdef SHARED. * sysdeps/unix/sysv/linux/arm/libc-vdso.h: Remove #ifdef SHARED. * sysdeps/unix/sysv/linux/arm/sysdep.h: Define ALWAYS_USE_VSYSCALL. --- ChangeLog | 8 ++++++++ sysdeps/unix/sysv/linux/arm/init-first.c | 9 ++++----- sysdeps/unix/sysv/linux/arm/libc-vdso.h | 6 +----- sysdeps/unix/sysv/linux/arm/sysdep.h | 3 +++ 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index c094c90440..a534c4a5f4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2018-12-03 Rafael Ávila de Espíndola + + [BZ #19767] + * sysdeps/unix/sysv/linux/arm/init-first.c: Remove #ifdef SHARED. + * sysdeps/unix/sysv/linux/arm/libc-vdso.h: Remove #ifdef SHARED. + * sysdeps/unix/sysv/linux/arm/sysdep.h: Define + ALWAYS_USE_VSYSCALL. + 2018-12-03 Adhemerval Zanella [BZ #23913] diff --git a/sysdeps/unix/sysv/linux/arm/init-first.c b/sysdeps/unix/sysv/linux/arm/init-first.c index f4293b1cf8..7fbdc27227 100644 --- a/sysdeps/unix/sysv/linux/arm/init-first.c +++ b/sysdeps/unix/sysv/linux/arm/init-first.c @@ -17,9 +17,9 @@ License along with the GNU C Library; if not, see . */ -#ifdef SHARED -# include -# include +#include +#include +#include int (*VDSO_SYMBOL(gettimeofday)) (struct timeval *, void *) attribute_hidden; int (*VDSO_SYMBOL(clock_gettime)) (clockid_t, struct timespec *); @@ -38,7 +38,6 @@ _libc_vdso_platform_setup (void) VDSO_SYMBOL (clock_gettime) = p; } -# define VDSO_SETUP _libc_vdso_platform_setup -#endif +#define VDSO_SETUP _libc_vdso_platform_setup #include diff --git a/sysdeps/unix/sysv/linux/arm/libc-vdso.h b/sysdeps/unix/sysv/linux/arm/libc-vdso.h index 52dd355818..2a8979d356 100644 --- a/sysdeps/unix/sysv/linux/arm/libc-vdso.h +++ b/sysdeps/unix/sysv/linux/arm/libc-vdso.h @@ -20,14 +20,10 @@ #ifndef _LIBC_VDSO_H #define _LIBC_VDSO_H -#ifdef SHARED - -# include +#include extern int (*VDSO_SYMBOL(gettimeofday)) (struct timeval *, void *) attribute_hidden; extern int (*VDSO_SYMBOL(clock_gettime)) (clockid_t, struct timespec *); -#endif - #endif /* _LIBC_VDSO_H */ diff --git a/sysdeps/unix/sysv/linux/arm/sysdep.h b/sysdeps/unix/sysv/linux/arm/sysdep.h index 174c530412..3902d46d55 100644 --- a/sysdeps/unix/sysv/linux/arm/sysdep.h +++ b/sysdeps/unix/sysv/linux/arm/sysdep.h @@ -20,6 +20,9 @@ #ifndef _LINUX_ARM_SYSDEP_H #define _LINUX_ARM_SYSDEP_H 1 +/* Always enable vsyscalls on arm */ +#define ALWAYS_USE_VSYSCALL 1 + /* There is some commonality. */ #include #include