mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-27 03:33:33 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix string/bug-strncat1.c build with GCC 8.

Browse Source 
GCC 8 warns about strncat calls with truncated output.
string/bug-strncat1.c tests such a call; this patch disables the
warning for it.

Tested (compilation) with GCC 8 for x86_64-linux-gnu with
build-many-glibcs.py (in conjunction with Martin's patch to allow
glibc to build).

	* string/bug-strncat1.c: Include <libc-diag.h>.
	(main): Disable -Wstringop-truncation for strncat call for GCC 8.

(cherry picked from commit ec72135e5f)
This commit is contained in:
Joseph Myers 2017-11-14 17:50:36 +00:00 committed by Florian Weimer
parent fe5978e1a5
commit 6ae2ca620a
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-11-14 Joseph Myers <joseph@codesourcery.com>
* string/bug-strncat1.c: Include <libc-diag.h>.
(main): Disable -Wstringop-truncation for strncat call for GCC 8.
2018-06-14 Joseph Myers <joseph@codesourcery.com>
* string/tester.c (test_strncat) [__GNUC_PREREQ (7, 0)]: Also

8
string/bug-strncat1.c
View File

@ -4,13 +4,21 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <libc-diag.h>
char d[3] = "\0\1\2";
int
main (void)
{
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (8, 0)
/* GCC 8 warns about strncat truncating output; this is deliberately
tested here. */
DIAG_IGNORE_NEEDS_COMMENT (8, "-Wstringop-truncation");
#endif
strncat (d, "\5\6", 1);
DIAG_POP_NEEDS_COMMENT;
if (d[0] != '\5')
{
puts ("d[0] != '\\5'");