mirrors/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-24 02:03:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[BZ 19170]

Browse Source 
Revise comment in sysdeps/hppa/dl-trampoline.S
This commit is contained in:
John David Anglin 2017-07-23 12:50:44 -04:00
parent 1740441b49
commit 64a1daed18
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-07-23 John David Anglin <danglin@gcc.gnu.org>
[BZ 19170]
* sysdeps/hppa/dl-trampoline.S (_dl_runtime_resolve): Revise comment.
2017-07-21 DJ Delorie <dj@redhat.com>
* nss/tst-nss-test5.c: Correct test configuration.

16
sysdeps/hppa/dl-trampoline.S
View File

@ -82,9 +82,19 @@ _dl_runtime_resolve:
bl _dl_fixup,%rp
copy %r21,%r19 /* set fixup func ltp */
/* Sometimes a final executable may attempt to call an undefined
weak function (e.g., __gmon_start__). Return if the function
was not resolved by _dl_fixup */
/* While the linker will set a function pointer to NULL when it
encounters an undefined weak function, we need to dynamically
detect removed weak functions. The issue arises because a weak
__gmon_start__ function was added to shared executables to work
around issues in _init that are now resolved. The presence of
__gmon_start__ in every shared library breaks the linker
`--as-needed' option. This __gmon_start__ function does nothing
but removal is tricky. Depending on the binding, removal can
cause an application using it to fault. The call to _dl_fixup
returns NULL when a function isn't resolved. In order to help
with __gmon_start__ removal, we return directly to the caller
when _dl_fixup returns NULL. This check could be removed when
BZ 19170 is fixed. */
comib,= 0,%r28,1f
/* Load up the returned func descriptor */