mirror of
https://github.com/git/git.git
synced 2024-11-23 18:05:29 +08:00
c4d9c79378
The headers 'diagnose.h', 'list-objects-filter-options.h',
'ref-filter.h' and 'remote.h' declare option parsing callback
functions with a 'struct option*' parameter, and 'revision.h' declares
an option parsing helper function taking 'struct parse_opt_ctx_t*' and
'struct option*' parameters. These headers all include
'parse-options.h', although they don't need any of the type
definitions from that header file. Furthermore,
'list-objects-filter-options.h' and 'ref-filter.h' also define some
OPT_* macros to initialize a 'struct option', but these don't
necessitate the inclusion of parse-options.h in these headers either,
because these macros are only expanded in source files.
Remove these unnecessary inclusions of parse-options.h and use forward
declarations to declare the necessary types.
After this patch none of the header files include parse-options.h
anymore.
With these changes, the build time after modifying only
parse-options.h is reduced by about 30%, and the number of targets
built is almost 20% less:
Before:
$ touch parse-options.h && time make -j4 |wc -l
353
real 1m1.527s
user 3m32.205s
sys 0m15.903s
After:
289
real 0m39.285s
user 2m12.540s
sys 0m11.164s
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
19 lines
337 B
C
19 lines
337 B
C
#ifndef DIAGNOSE_H
|
|
#define DIAGNOSE_H
|
|
|
|
#include "strbuf.h"
|
|
|
|
struct option;
|
|
|
|
enum diagnose_mode {
|
|
DIAGNOSE_NONE,
|
|
DIAGNOSE_STATS,
|
|
DIAGNOSE_ALL
|
|
};
|
|
|
|
int option_parse_diagnose(const struct option *opt, const char *arg, int unset);
|
|
|
|
int create_diagnostics_archive(struct strbuf *zip_path, enum diagnose_mode mode);
|
|
|
|
#endif /* DIAGNOSE_H */
|