mirror of
https://github.com/git/git.git
synced 2024-12-03 23:14:23 +08:00
fc78915674
When we have a multi-pack-index that covers many packfiles, we try to avoid opening the .idx for those packfiles. To do that we feed the pack name to midx_contains_pack(). But that function wants to see only the basename, which we compute using strrchr() to find the final slash. But that leaves an extra "/" at the start of our string. We can fix this by incrementing the pointer. That also raises the question of what to do when the name does not have a '/' at all. This should generally not happen (we always find files in "pack/"), but it doesn't hurt to be defensive here. Let's wrap all of that up in a helper function and make it publicly available, since a later patch will need to use it, too. The tests don't notice because there's nothing about opening those .idx files that would cause us to give incorrect output. It's just a little slower. The new test checks this case by corrupting the covered .idx, and then making sure we don't complain about it. We also have to tweak t5570, which intentionally corrupts a .idx file and expects us to notice it. When run with GIT_TEST_MULTI_PACK_INDEX, this will fail since we now will (correctly) not bother opening the .idx at all. We can fix that by unconditionally dropping any midx that's there, which ensures we'll have to read the .idx. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
367 lines
10 KiB
Bash
Executable File
367 lines
10 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='multi-pack-indexes'
|
|
. ./test-lib.sh
|
|
|
|
objdir=.git/objects
|
|
|
|
midx_read_expect () {
|
|
NUM_PACKS=$1
|
|
NUM_OBJECTS=$2
|
|
NUM_CHUNKS=$3
|
|
OBJECT_DIR=$4
|
|
EXTRA_CHUNKS="$5"
|
|
{
|
|
cat <<-EOF &&
|
|
header: 4d494458 1 $NUM_CHUNKS $NUM_PACKS
|
|
chunks: pack-names oid-fanout oid-lookup object-offsets$EXTRA_CHUNKS
|
|
num_objects: $NUM_OBJECTS
|
|
packs:
|
|
EOF
|
|
if test $NUM_PACKS -ge 1
|
|
then
|
|
ls $OBJECT_DIR/pack/ | grep idx | sort
|
|
fi &&
|
|
printf "object-dir: $OBJECT_DIR\n"
|
|
} >expect &&
|
|
test-tool read-midx $OBJECT_DIR >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success 'write midx with no packs' '
|
|
test_when_finished rm -f pack/multi-pack-index &&
|
|
git multi-pack-index --object-dir=. write &&
|
|
midx_read_expect 0 0 4 .
|
|
'
|
|
|
|
generate_objects () {
|
|
i=$1
|
|
iii=$(printf '%03i' $i)
|
|
{
|
|
test-tool genrandom "bar" 200 &&
|
|
test-tool genrandom "baz $iii" 50
|
|
} >wide_delta_$iii &&
|
|
{
|
|
test-tool genrandom "foo"$i 100 &&
|
|
test-tool genrandom "foo"$(( $i + 1 )) 100 &&
|
|
test-tool genrandom "foo"$(( $i + 2 )) 100
|
|
} >deep_delta_$iii &&
|
|
{
|
|
echo $iii &&
|
|
test-tool genrandom "$iii" 8192
|
|
} >file_$iii &&
|
|
git update-index --add file_$iii deep_delta_$iii wide_delta_$iii
|
|
}
|
|
|
|
commit_and_list_objects () {
|
|
{
|
|
echo 101 &&
|
|
test-tool genrandom 100 8192;
|
|
} >file_101 &&
|
|
git update-index --add file_101 &&
|
|
tree=$(git write-tree) &&
|
|
commit=$(git commit-tree $tree -p HEAD</dev/null) &&
|
|
{
|
|
echo $tree &&
|
|
git ls-tree $tree | sed -e "s/.* \\([0-9a-f]*\\) .*/\\1/"
|
|
} >obj-list &&
|
|
git reset --hard $commit
|
|
}
|
|
|
|
test_expect_success 'create objects' '
|
|
test_commit initial &&
|
|
for i in $(test_seq 1 5)
|
|
do
|
|
generate_objects $i
|
|
done &&
|
|
commit_and_list_objects
|
|
'
|
|
|
|
test_expect_success 'write midx with one v1 pack' '
|
|
pack=$(git pack-objects --index-version=1 $objdir/pack/test <obj-list) &&
|
|
test_when_finished rm $objdir/pack/test-$pack.pack \
|
|
$objdir/pack/test-$pack.idx $objdir/pack/multi-pack-index &&
|
|
git multi-pack-index --object-dir=$objdir write &&
|
|
midx_read_expect 1 18 4 $objdir
|
|
'
|
|
|
|
midx_git_two_modes () {
|
|
git -c core.multiPackIndex=false $1 >expect &&
|
|
git -c core.multiPackIndex=true $1 >actual &&
|
|
if [ "$2" = "sorted" ]
|
|
then
|
|
sort <expect >expect.sorted &&
|
|
mv expect.sorted expect &&
|
|
sort <actual >actual.sorted &&
|
|
mv actual.sorted actual
|
|
fi &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
compare_results_with_midx () {
|
|
MSG=$1
|
|
test_expect_success "check normal git operations: $MSG" '
|
|
midx_git_two_modes "rev-list --objects --all" &&
|
|
midx_git_two_modes "log --raw" &&
|
|
midx_git_two_modes "count-objects --verbose" &&
|
|
midx_git_two_modes "cat-file --batch-all-objects --batch-check" &&
|
|
midx_git_two_modes "cat-file --batch-all-objects --batch-check --unordered" sorted
|
|
'
|
|
}
|
|
|
|
test_expect_success 'write midx with one v2 pack' '
|
|
git pack-objects --index-version=2,0x40 $objdir/pack/test <obj-list &&
|
|
git multi-pack-index --object-dir=$objdir write &&
|
|
midx_read_expect 1 18 4 $objdir
|
|
'
|
|
|
|
compare_results_with_midx "one v2 pack"
|
|
|
|
test_expect_success 'corrupt idx not opened' '
|
|
idx=$(test-tool read-midx $objdir | grep "\.idx\$") &&
|
|
mv $objdir/pack/$idx backup-$idx &&
|
|
test_when_finished "mv backup-\$idx \$objdir/pack/\$idx" &&
|
|
|
|
# This is the minimum size for a sha-1 based .idx; this lets
|
|
# us pass perfunctory tests, but anything that actually opens and reads
|
|
# the idx file will complain.
|
|
test_copy_bytes 1064 <backup-$idx >$objdir/pack/$idx &&
|
|
|
|
git -c core.multiPackIndex=true rev-list --objects --all 2>err &&
|
|
test_must_be_empty err
|
|
'
|
|
|
|
test_expect_success 'add more objects' '
|
|
for i in $(test_seq 6 10)
|
|
do
|
|
generate_objects $i
|
|
done &&
|
|
commit_and_list_objects
|
|
'
|
|
|
|
test_expect_success 'write midx with two packs' '
|
|
git pack-objects --index-version=1 $objdir/pack/test-2 <obj-list &&
|
|
git multi-pack-index --object-dir=$objdir write &&
|
|
midx_read_expect 2 34 4 $objdir
|
|
'
|
|
|
|
compare_results_with_midx "two packs"
|
|
|
|
test_expect_success 'add more packs' '
|
|
for j in $(test_seq 11 20)
|
|
do
|
|
generate_objects $j &&
|
|
commit_and_list_objects &&
|
|
git pack-objects --index-version=2 $objdir/pack/test-pack <obj-list
|
|
done
|
|
'
|
|
|
|
compare_results_with_midx "mixed mode (two packs + extra)"
|
|
|
|
test_expect_success 'write midx with twelve packs' '
|
|
git multi-pack-index --object-dir=$objdir write &&
|
|
midx_read_expect 12 74 4 $objdir
|
|
'
|
|
|
|
compare_results_with_midx "twelve packs"
|
|
|
|
test_expect_success 'verify multi-pack-index success' '
|
|
git multi-pack-index verify --object-dir=$objdir
|
|
'
|
|
|
|
# usage: corrupt_midx_and_verify <pos> <data> <objdir> <string>
|
|
corrupt_midx_and_verify() {
|
|
POS=$1 &&
|
|
DATA="${2:-\0}" &&
|
|
OBJDIR=$3 &&
|
|
GREPSTR="$4" &&
|
|
COMMAND="$5" &&
|
|
if test -z "$COMMAND"
|
|
then
|
|
COMMAND="git multi-pack-index verify --object-dir=$OBJDIR"
|
|
fi &&
|
|
FILE=$OBJDIR/pack/multi-pack-index &&
|
|
chmod a+w $FILE &&
|
|
test_when_finished mv midx-backup $FILE &&
|
|
cp $FILE midx-backup &&
|
|
printf "$DATA" | dd of="$FILE" bs=1 seek="$POS" conv=notrunc &&
|
|
test_must_fail $COMMAND 2>test_err &&
|
|
grep -v "^+" test_err >err &&
|
|
test_i18ngrep "$GREPSTR" err
|
|
}
|
|
|
|
test_expect_success 'verify bad signature' '
|
|
corrupt_midx_and_verify 0 "\00" $objdir \
|
|
"multi-pack-index signature"
|
|
'
|
|
|
|
HASH_LEN=20
|
|
NUM_OBJECTS=74
|
|
MIDX_BYTE_VERSION=4
|
|
MIDX_BYTE_OID_VERSION=5
|
|
MIDX_BYTE_CHUNK_COUNT=6
|
|
MIDX_HEADER_SIZE=12
|
|
MIDX_BYTE_CHUNK_ID=$MIDX_HEADER_SIZE
|
|
MIDX_BYTE_CHUNK_OFFSET=$(($MIDX_HEADER_SIZE + 4))
|
|
MIDX_NUM_CHUNKS=5
|
|
MIDX_CHUNK_LOOKUP_WIDTH=12
|
|
MIDX_OFFSET_PACKNAMES=$(($MIDX_HEADER_SIZE + \
|
|
$MIDX_NUM_CHUNKS * $MIDX_CHUNK_LOOKUP_WIDTH))
|
|
MIDX_BYTE_PACKNAME_ORDER=$(($MIDX_OFFSET_PACKNAMES + 2))
|
|
MIDX_OFFSET_OID_FANOUT=$(($MIDX_OFFSET_PACKNAMES + 652))
|
|
MIDX_OID_FANOUT_WIDTH=4
|
|
MIDX_BYTE_OID_FANOUT_ORDER=$((MIDX_OFFSET_OID_FANOUT + 250 * $MIDX_OID_FANOUT_WIDTH + 1))
|
|
MIDX_OFFSET_OID_LOOKUP=$(($MIDX_OFFSET_OID_FANOUT + 256 * $MIDX_OID_FANOUT_WIDTH))
|
|
MIDX_BYTE_OID_LOOKUP=$(($MIDX_OFFSET_OID_LOOKUP + 16 * $HASH_LEN))
|
|
MIDX_OFFSET_OBJECT_OFFSETS=$(($MIDX_OFFSET_OID_LOOKUP + $NUM_OBJECTS * $HASH_LEN))
|
|
MIDX_OFFSET_WIDTH=8
|
|
MIDX_BYTE_PACK_INT_ID=$(($MIDX_OFFSET_OBJECT_OFFSETS + 16 * $MIDX_OFFSET_WIDTH + 2))
|
|
MIDX_BYTE_OFFSET=$(($MIDX_OFFSET_OBJECT_OFFSETS + 16 * $MIDX_OFFSET_WIDTH + 6))
|
|
|
|
test_expect_success 'verify bad version' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_VERSION "\00" $objdir \
|
|
"multi-pack-index version"
|
|
'
|
|
|
|
test_expect_success 'verify bad OID version' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_OID_VERSION "\02" $objdir \
|
|
"hash version"
|
|
'
|
|
|
|
test_expect_success 'verify truncated chunk count' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_CHUNK_COUNT "\01" $objdir \
|
|
"missing required"
|
|
'
|
|
|
|
test_expect_success 'verify extended chunk count' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_CHUNK_COUNT "\07" $objdir \
|
|
"terminating multi-pack-index chunk id appears earlier than expected"
|
|
'
|
|
|
|
test_expect_success 'verify missing required chunk' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_CHUNK_ID "\01" $objdir \
|
|
"missing required"
|
|
'
|
|
|
|
test_expect_success 'verify invalid chunk offset' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_CHUNK_OFFSET "\01" $objdir \
|
|
"invalid chunk offset (too large)"
|
|
'
|
|
|
|
test_expect_success 'verify packnames out of order' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_PACKNAME_ORDER "z" $objdir \
|
|
"pack names out of order"
|
|
'
|
|
|
|
test_expect_success 'verify packnames out of order' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_PACKNAME_ORDER "a" $objdir \
|
|
"failed to load pack"
|
|
'
|
|
|
|
test_expect_success 'verify oid fanout out of order' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_OID_FANOUT_ORDER "\01" $objdir \
|
|
"oid fanout out of order"
|
|
'
|
|
|
|
test_expect_success 'verify oid lookup out of order' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_OID_LOOKUP "\00" $objdir \
|
|
"oid lookup out of order"
|
|
'
|
|
|
|
test_expect_success 'verify incorrect pack-int-id' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_PACK_INT_ID "\07" $objdir \
|
|
"bad pack-int-id"
|
|
'
|
|
|
|
test_expect_success 'verify incorrect offset' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_OFFSET "\07" $objdir \
|
|
"incorrect object offset"
|
|
'
|
|
|
|
test_expect_success 'git-fsck incorrect offset' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_OFFSET "\07" $objdir \
|
|
"incorrect object offset" \
|
|
"git -c core.multipackindex=true fsck"
|
|
'
|
|
|
|
test_expect_success 'repack removes multi-pack-index' '
|
|
test_path_is_file $objdir/pack/multi-pack-index &&
|
|
GIT_TEST_MULTI_PACK_INDEX=0 git repack -adf &&
|
|
test_path_is_missing $objdir/pack/multi-pack-index
|
|
'
|
|
|
|
compare_results_with_midx "after repack"
|
|
|
|
test_expect_success 'multi-pack-index and pack-bitmap' '
|
|
git -c repack.writeBitmaps=true repack -ad &&
|
|
git multi-pack-index write &&
|
|
git rev-list --test-bitmap HEAD
|
|
'
|
|
|
|
test_expect_success 'multi-pack-index and alternates' '
|
|
git init --bare alt.git &&
|
|
echo $(pwd)/alt.git/objects >.git/objects/info/alternates &&
|
|
echo content1 >file1 &&
|
|
altblob=$(GIT_DIR=alt.git git hash-object -w file1) &&
|
|
git cat-file blob $altblob &&
|
|
git rev-list --all
|
|
'
|
|
|
|
compare_results_with_midx "with alternate (local midx)"
|
|
|
|
test_expect_success 'multi-pack-index in an alternate' '
|
|
mv .git/objects/pack/* alt.git/objects/pack &&
|
|
test_commit add_local_objects &&
|
|
git repack --local &&
|
|
git multi-pack-index write &&
|
|
midx_read_expect 1 3 4 $objdir &&
|
|
git reset --hard HEAD~1 &&
|
|
rm -f .git/objects/pack/*
|
|
'
|
|
|
|
compare_results_with_midx "with alternate (remote midx)"
|
|
|
|
# usage: corrupt_data <file> <pos> [<data>]
|
|
corrupt_data () {
|
|
file=$1
|
|
pos=$2
|
|
data="${3:-\0}"
|
|
printf "$data" | dd of="$file" bs=1 seek="$pos" conv=notrunc
|
|
}
|
|
|
|
# Force 64-bit offsets by manipulating the idx file.
|
|
# This makes the IDX file _incorrect_ so be careful to clean up after!
|
|
test_expect_success 'force some 64-bit offsets with pack-objects' '
|
|
mkdir objects64 &&
|
|
mkdir objects64/pack &&
|
|
for i in $(test_seq 1 11)
|
|
do
|
|
generate_objects 11
|
|
done &&
|
|
commit_and_list_objects &&
|
|
pack64=$(git pack-objects --index-version=2,0x40 objects64/pack/test-64 <obj-list) &&
|
|
idx64=objects64/pack/test-64-$pack64.idx &&
|
|
chmod u+w $idx64 &&
|
|
corrupt_data $idx64 2999 "\02" &&
|
|
midx64=$(git multi-pack-index --object-dir=objects64 write) &&
|
|
midx_read_expect 1 63 5 objects64 " large-offsets"
|
|
'
|
|
|
|
test_expect_success 'verify multi-pack-index with 64-bit offsets' '
|
|
git multi-pack-index verify --object-dir=objects64
|
|
'
|
|
|
|
NUM_OBJECTS=63
|
|
MIDX_OFFSET_OID_FANOUT=$((MIDX_OFFSET_PACKNAMES + 54))
|
|
MIDX_OFFSET_OID_LOOKUP=$((MIDX_OFFSET_OID_FANOUT + 256 * $MIDX_OID_FANOUT_WIDTH))
|
|
MIDX_OFFSET_OBJECT_OFFSETS=$(($MIDX_OFFSET_OID_LOOKUP + $NUM_OBJECTS * $HASH_LEN))
|
|
MIDX_OFFSET_LARGE_OFFSETS=$(($MIDX_OFFSET_OBJECT_OFFSETS + $NUM_OBJECTS * $MIDX_OFFSET_WIDTH))
|
|
MIDX_BYTE_LARGE_OFFSET=$(($MIDX_OFFSET_LARGE_OFFSETS + 3))
|
|
|
|
test_expect_success 'verify incorrect 64-bit offset' '
|
|
corrupt_midx_and_verify $MIDX_BYTE_LARGE_OFFSET "\07" objects64 \
|
|
"incorrect object offset"
|
|
'
|
|
|
|
test_done
|