mirror of
https://github.com/git/git.git
synced 2024-11-24 02:17:02 +08:00
35f6967161
Since some callers may want to send warning messages to somewhere other than stdout/stderr, stop printing "warning: Cannot merge binary files" from ll-merge and instead modify the return status of ll_merge() to indicate when a merge of binary files has occurred. Message printing probably does not belong in a "low-level merge" anyway. This commit continues printing the message as-is, just from the callers instead of within ll_merge(). Future changes will start handling the message differently in the merge-ort codepath. There was one special case here: the callers in rerere.c do NOT check for and print such a message; since those code paths explicitly skip over binary files, there is no reason to check for a return status of LL_MERGE_BINARY_CONFLICT or print the related message. Note that my methodology included first modifying ll_merge() to return a struct, so that the compiler would catch all the callers for me and ensure I had modified all of them. After modifying all of them, I then changed the struct to an enum. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
105 lines
2.2 KiB
C
105 lines
2.2 KiB
C
#include "cache.h"
|
|
#include "run-command.h"
|
|
#include "xdiff-interface.h"
|
|
#include "ll-merge.h"
|
|
#include "blob.h"
|
|
#include "merge-blobs.h"
|
|
#include "object-store.h"
|
|
|
|
static int fill_mmfile_blob(mmfile_t *f, struct blob *obj)
|
|
{
|
|
void *buf;
|
|
unsigned long size;
|
|
enum object_type type;
|
|
|
|
buf = read_object_file(&obj->object.oid, &type, &size);
|
|
if (!buf)
|
|
return -1;
|
|
if (type != OBJ_BLOB) {
|
|
free(buf);
|
|
return -1;
|
|
}
|
|
f->ptr = buf;
|
|
f->size = size;
|
|
return 0;
|
|
}
|
|
|
|
static void free_mmfile(mmfile_t *f)
|
|
{
|
|
free(f->ptr);
|
|
}
|
|
|
|
static void *three_way_filemerge(struct index_state *istate,
|
|
const char *path,
|
|
mmfile_t *base,
|
|
mmfile_t *our,
|
|
mmfile_t *their,
|
|
unsigned long *size)
|
|
{
|
|
enum ll_merge_result merge_status;
|
|
mmbuffer_t res;
|
|
|
|
/*
|
|
* This function is only used by cmd_merge_tree, which
|
|
* does not respect the merge.conflictstyle option.
|
|
* There is no need to worry about a label for the
|
|
* common ancestor.
|
|
*/
|
|
merge_status = ll_merge(&res, path, base, NULL,
|
|
our, ".our", their, ".their",
|
|
istate, NULL);
|
|
if (merge_status < 0)
|
|
return NULL;
|
|
if (merge_status == LL_MERGE_BINARY_CONFLICT)
|
|
warning("Cannot merge binary files: %s (%s vs. %s)",
|
|
path, ".our", ".their");
|
|
|
|
*size = res.size;
|
|
return res.ptr;
|
|
}
|
|
|
|
void *merge_blobs(struct index_state *istate, const char *path,
|
|
struct blob *base, struct blob *our,
|
|
struct blob *their, unsigned long *size)
|
|
{
|
|
void *res = NULL;
|
|
mmfile_t f1, f2, common;
|
|
|
|
/*
|
|
* Removed in either branch?
|
|
*
|
|
* NOTE! This depends on the caller having done the
|
|
* proper warning about removing a file that got
|
|
* modified in the other branch!
|
|
*/
|
|
if (!our || !their) {
|
|
enum object_type type;
|
|
if (base)
|
|
return NULL;
|
|
if (!our)
|
|
our = their;
|
|
return read_object_file(&our->object.oid, &type, size);
|
|
}
|
|
|
|
if (fill_mmfile_blob(&f1, our) < 0)
|
|
goto out_no_mmfile;
|
|
if (fill_mmfile_blob(&f2, their) < 0)
|
|
goto out_free_f1;
|
|
|
|
if (base) {
|
|
if (fill_mmfile_blob(&common, base) < 0)
|
|
goto out_free_f2_f1;
|
|
} else {
|
|
common.ptr = xstrdup("");
|
|
common.size = 0;
|
|
}
|
|
res = three_way_filemerge(istate, path, &common, &f1, &f2, size);
|
|
free_mmfile(&common);
|
|
out_free_f2_f1:
|
|
free_mmfile(&f2);
|
|
out_free_f1:
|
|
free_mmfile(&f1);
|
|
out_no_mmfile:
|
|
return res;
|
|
}
|