mirror of
https://github.com/git/git.git
synced 2024-11-25 02:44:48 +08:00
729b3925ed
In the interest of code hygiene, make it easier to compile Git with the
flag -pedantic.
Pure pedantic compilation with GCC 7.3 results in one warning per use of
the translation macro `N_`:
warning: array initialized from parenthesized string constant [-Wpedantic]
Therefore also disable the parenthesising of i18n strings with
-DUSE_PARENS_AROUND_GETTEXT_N=0.
Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
48 lines
1.4 KiB
Plaintext
48 lines
1.4 KiB
Plaintext
ifeq ($(filter no-error,$(DEVOPTS)),)
|
|
CFLAGS += -Werror
|
|
endif
|
|
ifneq ($(filter pedantic,$(DEVOPTS)),)
|
|
CFLAGS += -pedantic
|
|
# don't warn for each N_ use
|
|
CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
|
|
endif
|
|
CFLAGS += -Wdeclaration-after-statement
|
|
CFLAGS += -Wno-format-zero-length
|
|
CFLAGS += -Wold-style-definition
|
|
CFLAGS += -Woverflow
|
|
CFLAGS += -Wpointer-arith
|
|
CFLAGS += -Wstrict-prototypes
|
|
CFLAGS += -Wunused
|
|
CFLAGS += -Wvla
|
|
|
|
ifndef COMPILER_FEATURES
|
|
COMPILER_FEATURES := $(shell ./detect-compiler $(CC))
|
|
endif
|
|
|
|
ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
|
|
CFLAGS += -Wtautological-constant-out-of-range-compare
|
|
endif
|
|
|
|
ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
|
|
CFLAGS += -Wextra
|
|
# if a function is public, there should be a prototype and the right
|
|
# header file should be included. If not, it should be static.
|
|
CFLAGS += -Wmissing-prototypes
|
|
ifeq ($(filter extra-all,$(DEVOPTS)),)
|
|
# These are disabled because we have these all over the place.
|
|
CFLAGS += -Wno-empty-body
|
|
CFLAGS += -Wno-missing-field-initializers
|
|
CFLAGS += -Wno-sign-compare
|
|
CFLAGS += -Wno-unused-function
|
|
CFLAGS += -Wno-unused-parameter
|
|
endif
|
|
endif
|
|
|
|
# uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
|
|
# not worth fixing since newer compilers correctly stop complaining
|
|
ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
|
|
ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)
|
|
CFLAGS += -Wno-uninitialized
|
|
endif
|
|
endif
|