mirror of
https://github.com/git/git.git
synced 2024-11-24 18:33:43 +08:00
6636cf7e90
When we test deleting notes, we run "git notes remove" in a loop. However, the exit value of the loop will only reflect the final note we process. We should break out of the loop with a failing exit code as soon as we see a problem. Note that we can call "exit 1" here without explicitly creating a subshell, because the while loop on the right-hand side of a pipe executes in its own implicit subshell. Note also that the "break" above does not suffer the same problem; it is meant to exit the loop early at a certain number of iterations. We can bump it into the conditional of the loop to make this more obvious. Signed-off-by: Jeff King <peff@peff.net> Acked-by: Johan Herland <johan@herland.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
93 lines
1.8 KiB
Bash
Executable File
93 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='Test that adding/removing many notes triggers automatic fanout restructuring'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'creating many notes with git-notes' '
|
|
num_notes=300 &&
|
|
i=0 &&
|
|
while test $i -lt $num_notes
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
echo "file for commit #$i" > file &&
|
|
git add file &&
|
|
git commit -q -m "commit #$i" &&
|
|
git notes add -m "note #$i" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'many notes created correctly with git-notes' '
|
|
git log | grep "^ " > output &&
|
|
i=300 &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1));
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'many notes created with git-notes triggers fanout' '
|
|
# Expect entire notes tree to have a fanout == 1
|
|
git ls-tree -r --name-only refs/notes/commits |
|
|
while read path
|
|
do
|
|
case "$path" in
|
|
??/??????????????????????????????????????)
|
|
: true
|
|
;;
|
|
*)
|
|
echo "Invalid path \"$path\"" &&
|
|
return 1
|
|
;;
|
|
esac
|
|
done
|
|
'
|
|
|
|
test_expect_success 'deleting most notes with git-notes' '
|
|
num_notes=250 &&
|
|
i=0 &&
|
|
git rev-list HEAD |
|
|
while test $i -lt $num_notes && read sha1
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
git notes remove "$sha1" ||
|
|
exit 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'most notes deleted correctly with git-notes' '
|
|
git log HEAD~250 | grep "^ " > output &&
|
|
i=50 &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1));
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'deleting most notes triggers fanout consolidation' '
|
|
# Expect entire notes tree to have a fanout == 0
|
|
git ls-tree -r --name-only refs/notes/commits |
|
|
while read path
|
|
do
|
|
case "$path" in
|
|
????????????????????????????????????????)
|
|
: true
|
|
;;
|
|
*)
|
|
echo "Invalid path \"$path\"" &&
|
|
return 1
|
|
;;
|
|
esac
|
|
done
|
|
'
|
|
|
|
test_done
|