mirror of
https://github.com/git/git.git
synced 2024-11-23 18:05:29 +08:00
71c7916053
We have an execution path in apply_data that leaks the local struct
image. Plug it.
This leak can be triggered with:
$ echo foo >file
$ git add file && git commit -m file
$ echo bar >file
$ git diff file >diff
$ sed s/foo/frotz/ <diff >baddiff
$ git apply --cached <baddiff
Fixing this leak allows us to mark as leak-free the following tests:
+ t2016-checkout-patch.sh
+ t4103-apply-binary.sh
+ t4104-apply-boundary.sh
+ t4113-apply-ending.sh
+ t4117-apply-reject.sh
+ t4123-apply-shrink.sh
+ t4252-am-options.sh
+ t4258-am-quoted-cr.sh
Mark them with "TEST_PASSES_SANITIZE_LEAK=true" to notice and fix
promply any new leak that may be introduced and triggered by them in the
future.
Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
55 lines
722 B
Bash
Executable File
55 lines
722 B
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2006 Catalin Marinas
|
|
#
|
|
|
|
test_description='git apply trying to add an ending line.
|
|
|
|
'
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# setup
|
|
|
|
cat >test-patch <<\EOF
|
|
diff --git a/file b/file
|
|
--- a/file
|
|
+++ b/file
|
|
@@ -1,2 +1,3 @@
|
|
a
|
|
b
|
|
+c
|
|
EOF
|
|
|
|
echo 'a' >file
|
|
echo 'b' >>file
|
|
echo 'c' >>file
|
|
|
|
test_expect_success setup \
|
|
'git update-index --add file'
|
|
|
|
# test
|
|
|
|
test_expect_success 'apply at the end' \
|
|
'test_must_fail git apply --index test-patch'
|
|
|
|
cat >test-patch <<\EOF
|
|
diff a/file b/file
|
|
--- a/file
|
|
+++ b/file
|
|
@@ -1,2 +1,3 @@
|
|
+a
|
|
b
|
|
c
|
|
EOF
|
|
|
|
echo >file 'a
|
|
b
|
|
c'
|
|
git update-index file
|
|
|
|
test_expect_success 'apply at the beginning' \
|
|
'test_must_fail git apply --index test-patch'
|
|
|
|
test_done
|