mirror of
https://github.com/git/git.git
synced 2024-12-04 15:34:05 +08:00
7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
142 lines
3.3 KiB
Bash
Executable File
142 lines
3.3 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='Test that adding/removing many notes triggers automatic fanout restructuring'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
path_has_fanout() {
|
|
path=$1 &&
|
|
fanout=$2 &&
|
|
after_last_slash=$(($(test_oid hexsz) - $fanout * 2)) &&
|
|
echo $path | grep -q "^\([0-9a-f]\{2\}/\)\{$fanout\}[0-9a-f]\{$after_last_slash\}$"
|
|
}
|
|
|
|
touched_one_note_with_fanout() {
|
|
notes_commit=$1 &&
|
|
modification=$2 && # 'A' for addition, 'D' for deletion
|
|
fanout=$3 &&
|
|
diff=$(git diff-tree --no-commit-id --name-status --root -r $notes_commit) &&
|
|
path=$(echo $diff | sed -e "s/^$modification[\t ]//") &&
|
|
path_has_fanout "$path" $fanout;
|
|
}
|
|
|
|
all_notes_have_fanout() {
|
|
notes_commit=$1 &&
|
|
fanout=$2 &&
|
|
git ls-tree -r --name-only $notes_commit |
|
|
while read path
|
|
do
|
|
path_has_fanout $path $fanout || return 1
|
|
done
|
|
}
|
|
|
|
test_expect_success 'tweak test environment' '
|
|
git checkout -b nondeterminism &&
|
|
test_commit A &&
|
|
git checkout --orphan with_notes;
|
|
'
|
|
|
|
test_expect_success 'creating many notes with git-notes' '
|
|
num_notes=300 &&
|
|
i=0 &&
|
|
while test $i -lt $num_notes
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
echo "file for commit #$i" > file &&
|
|
git add file &&
|
|
git commit -q -m "commit #$i" &&
|
|
git notes add -m "note #$i" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success !SANITIZE_LEAK 'many notes created correctly with git-notes' '
|
|
git log >output.raw &&
|
|
grep "^ " output.raw >output &&
|
|
i=$num_notes &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1)) || return 1
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'stable fanout 0 is followed by stable fanout 1' '
|
|
i=$num_notes &&
|
|
fanout=0 &&
|
|
while test $i -gt 0
|
|
do
|
|
i=$(($i - 1)) &&
|
|
if touched_one_note_with_fanout refs/notes/commits~$i A $fanout
|
|
then
|
|
continue
|
|
elif test $fanout -eq 0
|
|
then
|
|
fanout=1 &&
|
|
if all_notes_have_fanout refs/notes/commits~$i $fanout
|
|
then
|
|
echo "Fanout 0 -> 1 at refs/notes/commits~$i" &&
|
|
continue
|
|
fi
|
|
fi &&
|
|
echo "Failed fanout=$fanout check at refs/notes/commits~$i" &&
|
|
git ls-tree -r --name-only refs/notes/commits~$i &&
|
|
return 1
|
|
done &&
|
|
all_notes_have_fanout refs/notes/commits 1
|
|
'
|
|
|
|
test_expect_success 'deleting most notes with git-notes' '
|
|
remove_notes=285 &&
|
|
i=0 &&
|
|
git rev-list HEAD >revs &&
|
|
while test $i -lt $remove_notes && read sha1
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
git notes remove "$sha1" || return 1
|
|
done <revs
|
|
'
|
|
|
|
test_expect_success 'most notes deleted correctly with git-notes' '
|
|
git log HEAD~$remove_notes | grep "^ " > output &&
|
|
i=$(($num_notes - $remove_notes)) &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1)) || return 1
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'stable fanout 1 is followed by stable fanout 0' '
|
|
i=$remove_notes &&
|
|
fanout=1 &&
|
|
while test $i -gt 0
|
|
do
|
|
i=$(($i - 1)) &&
|
|
if touched_one_note_with_fanout refs/notes/commits~$i D $fanout
|
|
then
|
|
continue
|
|
elif test $fanout -eq 1
|
|
then
|
|
fanout=0 &&
|
|
if all_notes_have_fanout refs/notes/commits~$i $fanout
|
|
then
|
|
echo "Fanout 1 -> 0 at refs/notes/commits~$i" &&
|
|
continue
|
|
fi
|
|
fi &&
|
|
echo "Failed fanout=$fanout check at refs/notes/commits~$i" &&
|
|
git ls-tree -r --name-only refs/notes/commits~$i &&
|
|
return 1
|
|
done &&
|
|
all_notes_have_fanout refs/notes/commits 0
|
|
'
|
|
|
|
test_done
|