mirror of
https://github.com/git/git.git
synced 2024-11-23 18:05:29 +08:00
509efef789
I forgot this in my previous patch `--pathspec-from-file` for
`git commit` [1]. When both `--pathspec-from-file` and `--all` were
specified, `--all` took precedence and `--pathspec-from-file` was
ignored. Before `--pathspec-from-file` was implemented, this case was
prevented by this check in `parse_and_validate_options()` :
die(_("paths '%s ...' with -a does not make sense"), argv[0]);
It is unfortunate that these two cases are disconnected. This came as
result of how the code was laid out before my patches, where `pathspec`
is parsed outside of `parse_and_validate_options()`. This branch is
already full of refactoring patches and I did not dare to go for another
one.
Fix by mirroring `die()` for `--pathspec-from-file` as well.
[1] Commit e440fc58 ("commit: support the --pathspec-from-file option" 2019-11-19)
Reported-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
137 lines
2.6 KiB
Bash
Executable File
137 lines
2.6 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='commit --pathspec-from-file'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_tick
|
|
|
|
test_expect_success setup '
|
|
test_commit file0 &&
|
|
git tag checkpoint &&
|
|
|
|
echo A >fileA.t &&
|
|
echo B >fileB.t &&
|
|
echo C >fileC.t &&
|
|
echo D >fileD.t &&
|
|
git add fileA.t fileB.t fileC.t fileD.t
|
|
'
|
|
|
|
restore_checkpoint () {
|
|
git reset --soft checkpoint
|
|
}
|
|
|
|
verify_expect () {
|
|
git diff-tree --no-commit-id --name-status -r HEAD >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success '--pathspec-from-file from stdin' '
|
|
restore_checkpoint &&
|
|
|
|
echo fileA.t | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success '--pathspec-from-file from file' '
|
|
restore_checkpoint &&
|
|
|
|
echo fileA.t >list &&
|
|
git commit --pathspec-from-file=list -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'NUL delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\0fileB.t\0" | git commit --pathspec-from-file=- --pathspec-file-nul -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'LF delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\nfileB.t\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'no trailing delimiter' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\nfileB.t" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'CRLF delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\r\nfileB.t\r\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'quotes' '
|
|
restore_checkpoint &&
|
|
|
|
printf "\"file\\101.t\"" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect expect
|
|
'
|
|
|
|
test_expect_success 'quotes not compatible with --pathspec-file-nul' '
|
|
restore_checkpoint &&
|
|
|
|
printf "\"file\\101.t\"" >list &&
|
|
test_must_fail git commit --pathspec-from-file=list --pathspec-file-nul -m "Commit"
|
|
'
|
|
|
|
test_expect_success 'only touches what was listed' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileB.t\nfileC.t\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileB.t
|
|
A fileC.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success '--pathspec-from-file and --all cannot be used together' '
|
|
restore_checkpoint &&
|
|
test_must_fail git commit --pathspec-from-file=- --all -m "Commit" 2>err &&
|
|
test_i18ngrep "[-]-pathspec-from-file with -a does not make sense" err
|
|
'
|
|
|
|
test_done
|