mirror of
https://github.com/git/git.git
synced 2024-11-24 10:26:17 +08:00
fe191fcaa5
git-svn by default puts its Subversion-tracking refs directly in refs/remotes/*. This runs counter to Git's convention of using refs/remotes/$remote/* for storing remote-tracking branches. Furthermore, combining git-svn with regular git remotes run the risk of clobbering refs under refs/remotes (e.g. if you have a git remote called "tags" with a "v1" branch, it will overlap with the git-svn's tracking branch for the "v1" tag from Subversion. Even though the git-svn refs stored in refs/remotes/* are not "proper" remote-tracking branches (since they are not covered by a proper git remote's refspec), they clearly represent a similar concept, and would benefit from following the same convention. For example, if git-svn tracks Subversion branch "foo" at refs/remotes/foo, and you create a local branch refs/heads/foo to add some commits to be pushed back to Subversion (using "git svn dcommit), then it is clearly unhelpful of Git to throw warning: refname 'foo' is ambiguous. every time you checkout, rebase, or otherwise interact with the branch. The existing workaround for this is to supply the --prefix=quux/ to git svn init/clone, so that git-svn's tracking branches end up in refs/remotes/quux/* instead of refs/remotes/*. However, encouraging users to specify --prefix to work around a design flaw in git-svn is suboptimal, and not a long term solution to the problem. Instead, git-svn should default to use a non-empty prefix that saves unsuspecting users from the inconveniences described above. This patch will only affect newly created git-svn setups, as the --prefix option only applies to git svn init (and git svn clone). Existing git-svn setups will continue with their existing (lack of) prefix. Also, if anyone somehow prefers git-svn's old layout, they can recreate that by explicitly passing an empty prefix (--prefix "") on the git svn init/clone command line. The patch changes the default value for --prefix from "" to "origin/", updates the git-svn manual page, and fixes the fallout in the git-svn testcases. (Note that this patch might be easier to review using the --word-diff and --word-diff-regex=. diff options.) [ew: squashed description of <= 1.9 behavior into manpage] Suggested-by: Thomas Ferris Nicolaisen <tfnico@gmail.com> Signed-off-by: Johan Herland <johan@herland.net> Signed-off-by: Eric Wong <normalperson@yhbt.net>
80 lines
2.0 KiB
Bash
Executable File
80 lines
2.0 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Kevin Ballard
|
|
#
|
|
|
|
test_description='git svn clone with percent escapes'
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'setup svnrepo' '
|
|
mkdir project project/trunk project/branches project/tags &&
|
|
echo foo > project/trunk/foo &&
|
|
svn_cmd import -m "$test_description" project "$svnrepo/pr ject" &&
|
|
svn_cmd cp -m "branch" "$svnrepo/pr ject/trunk" \
|
|
"$svnrepo/pr ject/branches/b" &&
|
|
svn_cmd cp -m "tag" "$svnrepo/pr ject/trunk" \
|
|
"$svnrepo/pr ject/tags/v1" &&
|
|
rm -rf project &&
|
|
start_httpd
|
|
'
|
|
|
|
test_expect_success 'test clone with percent escapes' '
|
|
git svn clone "$svnrepo/pr%20ject" clone &&
|
|
(
|
|
cd clone &&
|
|
git rev-parse refs/${remotes_git_svn}
|
|
)
|
|
'
|
|
|
|
# SVN works either way, so should we...
|
|
|
|
test_expect_success 'svn checkout with percent escapes' '
|
|
svn_cmd checkout "$svnrepo/pr%20ject" svn.percent &&
|
|
svn_cmd checkout "$svnrepo/pr%20ject/trunk" svn.percent.trunk
|
|
'
|
|
|
|
test_expect_success 'svn checkout with space' '
|
|
svn_cmd checkout "$svnrepo/pr ject" svn.space &&
|
|
svn_cmd checkout "$svnrepo/pr ject/trunk" svn.space.trunk
|
|
'
|
|
|
|
test_expect_success 'test clone trunk with percent escapes and minimize-url' '
|
|
git svn clone --minimize-url "$svnrepo/pr%20ject/trunk" minimize &&
|
|
(
|
|
cd minimize &&
|
|
git rev-parse refs/${remotes_git_svn}
|
|
)
|
|
'
|
|
|
|
test_expect_success 'test clone trunk with percent escapes' '
|
|
git svn clone "$svnrepo/pr%20ject/trunk" trunk &&
|
|
(
|
|
cd trunk &&
|
|
git rev-parse refs/${remotes_git_svn}
|
|
)
|
|
'
|
|
|
|
test_expect_success 'test clone --stdlayout with percent escapes' '
|
|
git svn clone --stdlayout "$svnrepo/pr%20ject" percent &&
|
|
(
|
|
cd percent &&
|
|
git rev-parse refs/remotes/origin/trunk^0 &&
|
|
git rev-parse refs/remotes/origin/b^0 &&
|
|
git rev-parse refs/remotes/origin/tags/v1^0
|
|
)
|
|
'
|
|
|
|
test_expect_success 'test clone -s with unescaped space' '
|
|
git svn clone -s "$svnrepo/pr ject" --prefix origin/ space &&
|
|
(
|
|
cd space &&
|
|
git rev-parse refs/remotes/origin/trunk^0 &&
|
|
git rev-parse refs/remotes/origin/b^0 &&
|
|
git rev-parse refs/remotes/origin/tags/v1^0
|
|
)
|
|
'
|
|
|
|
stop_httpd
|
|
|
|
test_done
|