mirror of
https://github.com/git/git.git
synced 2024-11-23 09:56:28 +08:00
a5e450144d
The chainlint tests are a series of individual files, each holding a
test body. The "make check-chainlint" target assembles them into a
single file, adding a "test_expect_success" function call around each.
Let's instead include that function call in the files themselves. This
is a little more boilerplate, but has several advantages:
1. You can now run chainlint manually on snippets with just "perl
chainlint.perl chainlint/foo.test". This can make developing and
debugging a little easier.
2. Many of the tests implicitly relied on the syntax of the lines
added by the Makefile (in particular the use of single-quotes).
This assumption is much easier to see when the single-quotes are
alongside the test body.
3. We had no way to test how the chainlint program handled
various test_expect_success lines themselves. Now we'll be able to
check variations.
The change to the .test files was done mechanically, using the same
test names they would have been assigned by the Makefile (this is
important to match the expected output). The Makefile has the minimal
change to drop the extra lines; there are more cleanups possible but a
future patch in this series will rewrite this substantially anyway.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
22 lines
344 B
Plaintext
22 lines
344 B
Plaintext
test_expect_success 'while-loop' '
|
|
(
|
|
# LINT: "while", "do", "done" do not need "&&"
|
|
while true
|
|
do
|
|
# LINT: missing "&&" on "echo"
|
|
echo foo
|
|
# LINT: last statement of while does not need "&&"
|
|
cat <<-\EOF
|
|
bar
|
|
EOF
|
|
# LINT: missing "&&" on "done"
|
|
done
|
|
|
|
# LINT: "do" on same line as "while"
|
|
while true; do
|
|
echo foo &&
|
|
cat bar
|
|
done
|
|
)
|
|
'
|