mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-24 02:17:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

write_file: use xopen

Browse Source 
This simplifies the code a tiny bit, and provides consistent
error messages with other users of xopen().

While we're here, let's also switch to using O_WRONLY. We
know we're only going to open/write/close the file, so
there's no point in asking for O_RDWR.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2016-07-08 05:10:08 -04:00 committed by Junio C Hamano
parent ef22318cff
commit ee861e0f78
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wrapper.c
View File

@ -644,9 +644,7 @@ void write_file(const char *path, const char *fmt, ...)
{ {
va_list params; va_list params;
struct strbuf sb = STRBUF_INIT; struct strbuf sb = STRBUF_INIT;
int fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0666); int fd = xopen(path, O_WRONLY | O_CREAT | O_TRUNC, 0666);
if (fd < 0)
die_errno(_("could not open %s for writing"), path);
va_start(params, fmt); va_start(params, fmt);
strbuf_vaddf(&sb, fmt, params); strbuf_vaddf(&sb, fmt, params);