mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-24 02:17:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

pack-objects: drop unused parameter from oe_map_new_pack()

Browse Source 
Since 43fa44fa3b (pack-objects: move in_pack out of struct object_entry,
2018-04-14), we store the source pack for each object as a small index
rather than as a pointer. When we see a new pack that has no allocated
index, we fall back to generating an array of pointers by calling
oe_map_new_pack().

Perhaps counter-intuitively, that function does not need to actually see
our new index-less pack. It only allocates and populates the array with
the existing packs, after which oe_set_in_pack() actually adds the new
pack to the array.

Let's drop the unused "struct packed_git" argument to oe_map_new_pack()
to avoid confusion.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2019-02-14 00:50:32 -05:00 committed by Junio C Hamano
parent b53c502807
commit c409d108b8
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pack-objects.c
View File

@ -119,8 +119,7 @@ static void prepare_in_pack_by_idx(struct packing_data *pdata)
* this fall back code, just stay simple and fall back to using * this fall back code, just stay simple and fall back to using
* in_pack[] array. * in_pack[] array.
*/ */
void oe_map_new_pack(struct packing_data *pack, void oe_map_new_pack(struct packing_data *pack)
struct packed_git *p)
{ {
uint32_t i; uint32_t i;

6
pack-objects.h
View File

@ -247,14 +247,14 @@ static inline struct packed_git *oe_in_pack(const struct packing_data *pack,
return pack->in_pack[e - pack->objects]; return pack->in_pack[e - pack->objects];
} }
void oe_map_new_pack(struct packing_data *pack, void oe_map_new_pack(struct packing_data *pack);
struct packed_git *p);
static inline void oe_set_in_pack(struct packing_data *pack, static inline void oe_set_in_pack(struct packing_data *pack,
struct object_entry *e, struct object_entry *e,
struct packed_git *p) struct packed_git *p)
{ {
if (!p->index) if (!p->index)
oe_map_new_pack(pack, p); oe_map_new_pack(pack);
if (pack->in_pack_by_idx) if (pack->in_pack_by_idx)
e->in_pack_idx = p->index; e->in_pack_idx = p->index;
else else