mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-24 02:17:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

git-mktag: be more careful in reading the input.

Browse Source 
Instead of always assuming it can be read with a single
read() system call, loop around properly.

Pointed out by Pasky, but I ended up implementing it differently
from his suggested patch.
This commit is contained in:
Linus Torvalds 2005-05-29 12:06:32 -07:00
parent 8b7d510fb1
commit b97e3dfa76
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mktag.c
View File

@ -106,7 +106,18 @@ int main(int argc, char **argv)
usage("cat <signaturefile> | git-mktag");
// Read the signature
size = read(0, buffer, MAXSIZE);
size = 0;
for (;;) {
int ret = read(0, buffer + size, MAXSIZE - size);
if (!ret)
break;
if (ret < 0) {
if (errno == EAGAIN)
continue;
break;
}
size += ret;
}
// Verify it for some basic sanity: it needs to start with "object <sha1>\ntype "
if (verify_tag(buffer, size) < 0)