git-applymbox: allow retrying after fixing up.

After failing to apply a patch, when operating under -q (query)
flag, give the user an opportunity to fix up the patch in a
separate window and retry.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2005-07-29 15:37:11 -07:00
parent 638ccfdf0e
commit b50abe8843

View File

@ -9,7 +9,7 @@
## You give it a mbox-format collection of emails, and it will try to ## You give it a mbox-format collection of emails, and it will try to
## apply them to the kernel using "applypatch" ## apply them to the kernel using "applypatch"
## ##
## applymbox [ -c .dotest/msg-number ] [ -q ] mail_archive [Signoff_file]" ## applymbox [ -q ] (-c .dotest/msg-number | mail_archive) [Signoff_file]"
## ##
## The patch application may fail in the middle. In which case: ## The patch application may fail in the middle. In which case:
## (1) look at .dotest/patch and fix it up to apply ## (1) look at .dotest/patch and fix it up to apply
@ -35,14 +35,19 @@ case "$continue" in
rm -rf .dotest rm -rf .dotest
mkdir .dotest mkdir .dotest
git-mailsplit "$1" .dotest || exit 1 git-mailsplit "$1" .dotest || exit 1
shift
esac esac
case "$query_apply" in case "$query_apply" in
t) touch .dotest/.query_apply t) touch .dotest/.query_apply
esac esac
for i in .dotest/0* signoff="$1"
set x .dotest/0*
shift
while case "$#" in 0) break;; esac
do do
i="$1"
case "$resume,$continue" in case "$resume,$continue" in
f,$i) resume=t;; f,$i) resume=t;;
f,*) continue;; f,*) continue;;
@ -51,13 +56,34 @@ do
git-stripspace < .dotest/msg > .dotest/msg-clean git-stripspace < .dotest/msg > .dotest/msg-clean
;; ;;
esac esac
git-applypatch .dotest/msg-clean .dotest/patch .dotest/info "$2" while :; # for fixing up and retry
ret=$? do
if [ $ret -ne 0 ]; then git-applypatch .dotest/msg-clean .dotest/patch .dotest/info "$signoff"
case "$?" in
0 | 2 )
# 2 is a special exit code from applypatch to indicate that # 2 is a special exit code from applypatch to indicate that
# the patch wasn't applied, but continue anyway # the patch wasn't applied, but continue anyway
[ $ret -ne 2 ] && exit $ret ;;
*)
ret=$?
if test -f .dotest/.query_apply
then
echo >&2 "* Patch failed."
echo >&2 "* You could fix it up in your editor and"
echo >&2 " retry. If you want to do so, say yes here"
echo >&2 " AFTER fixing .dotest/patch up."
echo >&2 -n "Retry [y/N]? "
read yesno
case "$yesno" in
[Yy]*)
continue ;;
esac
fi fi
exit $ret
esac
break
done
shift
done done
# return to pristine # return to pristine
rm -fr .dotest rm -fr .dotest