mirror of
https://github.com/git/git.git
synced 2024-11-24 02:17:02 +08:00
git-repack: avoid redirecting stderr into git-pack-objects
We are trying to catch error condition of git-rev-list and cause the downstream pack-objects to barf, but if you run rev-list with anything that mucks with its stderr (such as GIT_TRACE), any stderr output would cause the pipeline to fail. [jc: originally from Matthias Lederhofer, with a reworded error message.] Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
parent
869659a6a1
commit
a72f9373c0
@ -43,7 +43,9 @@ case ",$all_into_one," in
|
||||
;;
|
||||
esac
|
||||
pack_objects="$pack_objects $local $quiet $no_reuse_delta$extra"
|
||||
name=$(git-rev-list --objects --all $rev_list 2>&1 |
|
||||
name=$( { git-rev-list --objects --all $rev_list ||
|
||||
echo "git-rev-list died with exit code $?"
|
||||
} |
|
||||
git-pack-objects --non-empty $pack_objects .tmp-pack) ||
|
||||
exit 1
|
||||
if [ -z "$name" ]; then
|
||||
|
Loading…
Reference in New Issue
Block a user