mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2025-01-06 07:33:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

test-hashmap: use "unsigned int" for hash storage

Browse Source 
The hashmap API always use an unsigned value for storing
and comparing hashes. Whereas this test code uses "int".
This works out in practice since one can typically
round-trip between "int" and "unsigned int". But since this
is essentially reference code for the hashmap API, we should
model using the correct types.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2018-02-14 13:08:57 -05:00 committed by Junio C Hamano
parent 7daa825d67
commit a6119f82b1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
t/helper/test-hashmap.c
View File

@ -30,7 +30,8 @@ static int test_entry_cmp(const void *cmp_data,
return strcmp(e1->key, key ? key : e2->key); return strcmp(e1->key, key ? key : e2->key);
} }
static struct test_entry *alloc_test_entry(int hash, char *key, char *value) static struct test_entry *alloc_test_entry(unsigned int hash,
char *key, char *value)
{ {
size_t klen = strlen(key); size_t klen = strlen(key);
size_t vlen = strlen(value); size_t vlen = strlen(value);
@ -156,7 +157,7 @@ int cmd_main(int argc, const char **argv)
/* process commands from stdin */ /* process commands from stdin */
while (strbuf_getline(&line, stdin) != EOF) { while (strbuf_getline(&line, stdin) != EOF) {
char *cmd, *p1 = NULL, *p2 = NULL; char *cmd, *p1 = NULL, *p2 = NULL;
int hash = 0; unsigned int hash = 0;
struct test_entry *entry; struct test_entry *entry;
/* break line into command and up to two parameters */ /* break line into command and up to two parameters */