mirror of
https://github.com/git/git.git
synced 2024-11-27 03:53:55 +08:00
pretty: fix leaking key/value separator buffer
The `format_set_trailers_options()` function is responsible for parsing a custom pretty format for trailers. It puts the parsed options into a `struct process_trailer_options` structure, while the allocated memory required for this will be put into separate caller-provided arguments. It is thus the caller's responsibility to free the memory not via the options structure, but via the other parameters. While we do this alright for the separator and filter keys, we do not free the memory associated with the key/value separator. Fix this to plug this memory leak. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
60289b50d0
commit
82ea7e59b2
1
pretty.c
1
pretty.c
@ -1776,6 +1776,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
|
||||
}
|
||||
trailer_out:
|
||||
string_list_clear(&filter_list, 0);
|
||||
strbuf_release(&kvsepbuf);
|
||||
strbuf_release(&sepbuf);
|
||||
return ret;
|
||||
}
|
||||
|
@ -5,6 +5,8 @@
|
||||
#
|
||||
|
||||
test_description='Test pretty formats'
|
||||
|
||||
TEST_PASSES_SANITIZE_LEAK=true
|
||||
. ./test-lib.sh
|
||||
|
||||
# Tested non-UTF-8 encoding
|
||||
|
Loading…
Reference in New Issue
Block a user