mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-23 18:05:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Libified diff-index: backward compatibility fix.

Browse Source 
"diff-index -m" does not mean "do not ignore merges", but means
"pretend missing files match the index".

The previous round tried to address this, but failed because
setup_revisions() ate "-m" flag before the caller had a chance
to intervene.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2006-04-22 03:58:04 -07:00
parent e09ad6e1e3
commit 5c21ac0e7c
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
diff-index.c
View File

@ -23,9 +23,7 @@ int main(int argc, const char **argv)
for (i = 1; i < argc; i++) {
const char *arg = argv[i];
if (!strcmp(arg, "-m"))
match_missing = 1;
else if (!strcmp(arg, "--cached"))
if (!strcmp(arg, "--cached"))
cached = 1;
else
usage(diff_cache_usage);
@ -37,5 +35,5 @@ int main(int argc, const char **argv)
if (!rev.pending_objects || rev.pending_objects->next ||
rev.max_count != -1 || rev.min_age != -1 || rev.max_age != -1)
usage(diff_cache_usage);
return run_diff_index(&rev, cached, match_missing);
return run_diff_index(&rev, cached);
}

10
diff-lib.c
View File

@ -308,12 +308,20 @@ static void mark_merge_entries(void)
}
}
int run_diff_index(struct rev_info *revs, int cached, int match_missing)
int run_diff_index(struct rev_info *revs, int cached)
{
int ret;
struct object *ent;
struct tree *tree;
const char *tree_name;
int match_missing = 0;
/*
* Backward compatibility wart - "diff-index -m" does
* not mean "do not ignore merges", but totally different.
*/
if (!revs->ignore_merges)
match_missing = 1;
if (read_cache() < 0) {
perror("read_cache");

2
diff.h
View File

@ -171,6 +171,6 @@ extern const char *diff_unique_abbrev(const unsigned char *, int);
extern int run_diff_files(struct rev_info *revs, int silent_on_removed);
extern int run_diff_index(struct rev_info *revs, int cached, int match_missing);
extern int run_diff_index(struct rev_info *revs, int cached);
#endif /* DIFF_H */