mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2025-01-24 08:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

http-backend: Fix access beyond end of string.

Browse Source 
Found with valgrind while looking for Content-Length corruption in
smart http.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Tarmigan Casebolt 2009-11-14 13:10:57 -08:00 committed by Junio C Hamano
parent 4a5328d644
commit 48aec1b1f1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
http-backend.c
View File

@ -615,7 +615,7 @@ int main(int argc, char **argv)
if (regcomp(&re, c->pattern, REG_EXTENDED))
die("Bogus regex in service table: %s", c->pattern);
if (!regexec(&re, dir, 1, out, 0)) {
size_t n = out[0].rm_eo - out[0].rm_so;
size_t n;
if (strcmp(method, c->method)) {
const char *proto = getenv("SERVER_PROTOCOL");
@ -629,9 +629,10 @@ int main(int argc, char **argv)
}
cmd = c;
n = out[0].rm_eo - out[0].rm_so;
cmd_arg = xmalloc(n);
strncpy(cmd_arg, dir + out[0].rm_so + 1, n);
cmd_arg[n] = '\0';
memcpy(cmd_arg, dir + out[0].rm_so + 1, n-1);
cmd_arg[n-1] = '\0';
dir[out[0].rm_so] = 0;
break;
}